darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 16:24:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

Improve display of failure rates

Browse Source 
https://www.pivotaltracker.com/story/show/116052359

- add absolute numbers for failures
- make percentages accurate to 1 decimal place (50.0%)
- make error colour appear if failures go above 3.0%
- make error colour boolean (don’t interpolate between the colours)
This commit is contained in:
Chris Hill-Scott
2016-03-23 09:21:35 +00:00
parent 4411f8cb37
commit 45ea12e13f
4 changed files with 33 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/templates/components/big-number.html
View File

@@ -6,12 +6,15 @@
{% endmacro %}
{% macro big_number_with_status(number, label, status_number, status_label, percentage_bad=0) %}
{% macro big_number_with_status(number, label, failures, failure_percentage, danger_zone=False) %}
<div class="big-number-with-status">
{{ big_number(number, label) }}
<div class="big-number-status">
<div class="big-number-status-error-percentage" style="opacity: {{ percentage_bad / 100 }}"></div>
{{ big_number(status_number, status_label) }}
<div class="big-number-status{% if danger_zone %}-failing{% endif %}">
{% if failures %}
{{ failures }} failed – {{ failure_percentage }}%
{% else %}
No failures
{% endif %}
</div>
</div>
{% endmacro %}