darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-24 01:49:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor go-live readyness into service model

Browse Source 
All this info is info about the service. So it’s better to put it on
the service model because:
- encapsulation
- later reuse
This commit is contained in:
Chris Hill-Scott
2018-09-20 09:43:28 +01:00
parent d753e8351c
commit 45b1b11abb
4 changed files with 57 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
app/main/views/service_settings.py
View File

@@ -180,30 +180,7 @@ def service_name_change_confirm(service_id):
@user_has_permissions('manage_service')
def request_to_go_live(service_id):
return render_template(
'views/service-settings/request-to-go-live.html',
has_team_members=(
user_api_client.get_count_of_users_with_permission(
service_id, 'manage_service'
) > 1
),
has_templates=(
service_api_client.count_service_templates(service_id) > 0
),
has_email_templates=(
service_api_client.count_service_templates(service_id, template_type='email') > 0
),
has_sms_templates=(
service_api_client.count_service_templates(service_id, template_type='sms') > 0
),
has_email_reply_to_address=bool(
service_api_client.get_reply_to_email_addresses(service_id)
),
shouldnt_use_govuk_as_sms_sender=(
current_service.organisation_type in {'local', 'nhs'}
),
sms_sender_is_govuk=get_default_sms_sender(
service_api_client.get_sms_senders(service_id)
) in {'GOVUK', 'None'},
'views/service-settings/request-to-go-live.html'
)