darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-06 16:58:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor into model

Browse Source 
It’s generally an antipattern for the view layer code to be calling the
API client directly.
This commit is contained in:
Chris Hill-Scott
2021-06-07 13:51:39 +01:00
parent 1b459d6692
commit 45645728c7
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/main/views/webauthn_credentials.py
View File

@@ -52,9 +52,7 @@ def webauthn_complete_register():
current_app.logger.info(f'User {current_user.id} could not register a new webauthn token - {e}') current_app.logger.info(f'User {current_user.id} could not register a new webauthn token - {e}')
return cbor.encode(str(e)), 400 return cbor.encode(str(e)), 400
user_api_client.create_webauthn_credential_for_user( current_user.create_webauthn_credential(credential)
current_user.id, credential
)
flash(( flash((
'Registration complete. Next time you sign in to Notify ' 'Registration complete. Next time you sign in to Notify '

5
app/models/user.py
View File

@@ -360,6 +360,11 @@ class User(JSONModel, UserMixin):
for credential in self.webauthn_credentials for credential in self.webauthn_credentials
] ]
def create_webauthn_credential(self, credential):
user_api_client.create_webauthn_credential_for_user(
self.id, credential
)
def serialize(self): def serialize(self):
dct = { dct = {
"id": self.id, "id": self.id,