darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Store boolean values in Redis as valid JSON

Browse Source 
Calling `.set()` with `True` stores the byte string `'True'` which
cannot subsequently be decoded from JSON (because boolean values in
JSON are lowercase, ie `true`).
This commit is contained in:
Chris Hill-Scott
2018-07-31 12:17:28 +01:00
parent 1073b8f178
commit 45579c59cd
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/notify_client/job_api_client.py
View File

@@ -90,7 +90,7 @@ class JobApiClient(NotifyAdminAPIClient):
self.redis_client.set( self.redis_client.set(
'has_jobs-{}'.format(service_id), 'has_jobs-{}'.format(service_id),
True, b'true',
ex=cache.TTL, ex=cache.TTL,
) )

2
tests/app/notify_client/test_job_client.py
View File

@@ -29,7 +29,7 @@ def test_client_creates_job_data_correctly(mocker, fake_uuid):
mock_post.assert_called_once_with(url=expected_url, data=expected_data) mock_post.assert_called_once_with(url=expected_url, data=expected_data)
mock_redis_set.assert_called_once_with( mock_redis_set.assert_called_once_with(
'has_jobs-{}'.format(service_id), 'has_jobs-{}'.format(service_id),
True, b'true',
ex=604800, ex=604800,
) )