Make the selected pill item a link

All other navigations have their selected item as
a link so we should match this.

Includes changes to the pill CSS so:
1. it doesn't use elements in the selectors
2. all the selectors use BEM

I did 2. because I had to change the
classes/selectors anyway, they might as well match
the style GOVUK Design System uses.
This commit is contained in:
Tom Byers
2020-09-04 13:32:34 +01:00
parent c6711a113c
commit 452e253e2c
2 changed files with 26 additions and 24 deletions

View File

@@ -2,7 +2,7 @@
display: flex;
li {
&-item__container {
width: 25%;
flex-grow: 1;
text-align: left;
@@ -23,8 +23,8 @@
display: flex;
}
a,
&-selected-item {
&-item,
&-item--selected {
display: flex; // float causes display: block in browsers without flexbox
flex-direction: column;
justify-content: center;
@@ -34,7 +34,7 @@
padding: 10px 0;
}
a {
&-item {
$background: $link-colour;
background: $background;
color: $white;
@@ -43,10 +43,6 @@
text-decoration: none;
cursor: pointer;
.pill-label {
text-decoration: underline;
}
&:link,
&:visited {
color: $white;
@@ -62,13 +58,23 @@
}
}
&-selected-item {
&-item--selected {
background: inherit;
border: 2px solid $black;
outline: 1px solid rgba($white, 0.1);
position: relative;
z-index: 10;
color: $text-colour;
&:link,
&:visited {
color: $govuk-text-colour;
}
&:hover {
color: govuk-tint($govuk-text-colour, 25%);
}
&:active,
&:focus {
z-index: 1000;
outline: 3px solid $yellow;
@@ -76,8 +82,9 @@
}
&-label {
&-item__label {
text-decoration: underline;
// reduce padding until screen is above 420px / zoomed below 300%
padding-left: govuk-spacing(1);
@@ -87,7 +94,7 @@
}
&-centered-item {
&-item--centered {
text-align: center;
padding-left: 0;
}