darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-07 16:58:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

Code refactor, details below:

Browse Source 
Apply suggestions from code review

Reduce max verification waiting time to 90 seconds

Also minor changes following peer review

Co-Authored-By: Chris Hill-Scott <me@quis.cc>

Use constants for notification status collections on verify reply-to

email address

Use a cleaner way of adding request arguments to url_for()
This commit is contained in:
Pea (Malgorzata Tyczynska)
2019-05-21 16:08:50 +01:00
committed by Pea Tyczynska
parent 200fff6c66
commit 44ddd287b5
3 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/templates/views/service-settings/email-reply-to/_verify-updates.html
View File

@@ -11,11 +11,11 @@
We’re checking that ‘{{ reply_to_email_address }}’ is a real email address.
</p>
<p>
<span class='loading-indicator'>This can take a minute </span>
<span class='loading-indicator'>This can take a minute</span>
</p>
<p>
<a href="{{ url_for('main.service_verify_reply_to_address', service_id=service_id, notification_id=notification_id) + "?is_default={}".format(is_default) }}"">Refresh</a>
<a href="{{ url_for('main.service_verify_reply_to_address', service_id=service_id, notification_id=notification_id, is_default=is_default, replace=replace) }}"">Refresh</a>
</p>
{% elif verification_status == "success" %}
{{ banner("‘{}’ is ready to use".format(reply_to_email_address), type='default', with_tick=True) }}

2
app/templates/views/service-settings/email-reply-to/verify.html
View File

@@ -22,7 +22,7 @@
) }}
{{ ajax_block(
partials,
url_for('main.service_verify_reply_to_address_updates', service_id=service_id, notification_id=notification_id) + request_args,
url_for('main.service_verify_reply_to_address_updates', service_id=service_id, notification_id=notification_id, is_default=is_default, replace=replace),
'status',
finished=finished
) }}