darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-05 15:08:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2708 from alphagov/fix-sticky-overflow-final-final

Browse Source 
Add adjustment for padding missed from previous
This commit is contained in:
Tom Byers
2019-01-31 16:57:43 +00:00
committed by GitHub
parent aa74977315 fd3ca31e44
commit 4446f40b38
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/stick-to-window-when-scrolling.js
View File

@@ -197,10 +197,12 @@
// if next to opposite edge to the one the dialog is stuck to, no offset // if next to opposite edge to the one the dialog is stuck to, no offset
if (elIdx === (els.length - 1)) { return 0; } if (elIdx === (els.length - 1)) { return 0; }
// get all els between this one and the opposite edge // make els all those from this one to the window edge
els = els.slice(elIdx + 1); els = els.slice(elIdx);
// get all els between this one and the window edge
elsBetween = els.slice(1);
return this._getTotalHeight(els); return this._getTotalHeight(elsBetween) - this._getPaddingBetweenEls(els);
}, },
// checks total height of all this._sticky elements against a height // checks total height of all this._sticky elements against a height
// unsticks each that won't fit and marks them as unstickable // unsticks each that won't fit and marks them as unstickable