Replace test with one-off

It’s a confusing proposition to have two features which are almost
identical. Even differentiating between them in the template menu would
be tricky.

I think the better thing to do is rename the whole feature to ‘send
one-off message’.

Then if someone wants to use there own phone number or email address,
give them a quick shortcut to doing that, once they’re in the flow.
In the background this reuses the ‘send yourself a test’ code, but
the user is never aware that they’re going through a different route
to send an individual message. So the proposition stays nice and clean.
This commit is contained in:
Chris Hill-Scott
2017-05-25 13:31:51 +01:00
parent 82549c817a
commit 43f6d21e1d
7 changed files with 100 additions and 24 deletions

View File

@@ -282,13 +282,25 @@ def send_test_step(service_id, template_id, step_index):
template.values = get_normalised_send_test_values_from_session()
template.values[current_placeholder] = None
if (
request.endpoint == 'main.send_one_off_step' and
step_index == 0 and
template.template_type != 'letter'
):
skip_link = (
'Use my {}'.format(first_column_headings[template.template_type][0]),
url_for('.send_test', service_id=service_id, template_id=template.id),
)
else:
skip_link = None
return render_template(
'views/send-test.html',
page_title=get_send_test_page_title(template.template_type, request.endpoint),
page_title=get_send_test_page_title(template.template_type, get_help_argument()),
template=template,
form=form,
skip_link=skip_link,
optional_placeholder=optional_placeholder,
help=get_help_argument(),
back_link=back_link,
)
@@ -549,12 +561,9 @@ def all_placeholders_in_session(placeholders):
)
def get_send_test_page_title(template_type, endpoint):
if get_help_argument():
def get_send_test_page_title(template_type, help_argument):
if help_argument:
return 'Example text message'
if template_type == 'letter':
return 'Print a test letter'
return {
'main.send_test_step': 'Send yourself a test',
'main.send_one_off_step': 'Send one-off message',
}[endpoint]
return 'Send one-off message'