From 422b4c10919a094ad12dc56c9b98783cb09b0ae7 Mon Sep 17 00:00:00 2001 From: Ben Thorner Date: Thu, 24 Mar 2022 12:58:56 +0000 Subject: [PATCH] Show link to service history in the settings page Based on discussion in [^1]. [^1]: https://github.com/alphagov/notifications-admin/pull/4157 --- app/templates/views/service-settings.html | 12 ++++++++++++ .../test_service_setting_permissions.py | 4 +++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/app/templates/views/service-settings.html b/app/templates/views/service-settings.html index 5320a617c..d7ade8672 100644 --- a/app/templates/views/service-settings.html +++ b/app/templates/views/service-settings.html @@ -471,6 +471,12 @@ Suspend service + + + + Service history + + {% endif %}

{% endif %} @@ -485,6 +491,12 @@ Resume service + + + + Service history + +

{% endif %} diff --git a/tests/app/main/views/service_settings/test_service_setting_permissions.py b/tests/app/main/views/service_settings/test_service_setting_permissions.py index 6712463b0..e2472ce5a 100644 --- a/tests/app/main/views/service_settings/test_service_setting_permissions.py +++ b/tests/app/main/views/service_settings/test_service_setting_permissions.py @@ -151,9 +151,11 @@ def test_service_setting_toggles_show( @pytest.mark.parametrize('service_fields, endpoint, index, text', [ ({'active': True}, '.archive_service', 0, 'Delete this service'), ({'active': True}, '.suspend_service', 1, 'Suspend service'), + ({'active': True}, '.history', 2, 'Service history'), ({'active': False}, '.resume_service', 0, 'Resume service'), + ({'active': False}, '.history', 1, 'Service history'), pytest.param( - {'active': False}, '.archive_service', 1, 'Resume service', + {'active': False}, '.archive_service', 2, 'Resume service', marks=pytest.mark.xfail(raises=IndexError) ) ])