From 422b1fb5c2198a6d2436d2368f83d515617764d1 Mon Sep 17 00:00:00 2001 From: Adam Shimali Date: Wed, 20 Jan 2016 09:43:38 +0000 Subject: [PATCH] uncomment accidentally commented out tests --- tests/app/main/views/test_register.py | 100 +++++++++++++------------- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/tests/app/main/views/test_register.py b/tests/app/main/views/test_register.py index 3224fa7c6..83e6aeef5 100644 --- a/tests/app/main/views/test_register.py +++ b/tests/app/main/views/test_register.py @@ -32,63 +32,63 @@ def test_process_register_creates_new_user(app_, assert response.location == url_for('main.verify', _external=True) -# def test_process_register_returns_400_when_mobile_number_is_invalid(app_, -# db_, -# db_session, -# mock_send_sms, -# mock_send_email): -# response = app_.test_client().post('/register', -# data={'name': 'Bad Mobile', -# 'email_address': 'bad_mobile@example.gov.uk', -# 'mobile_number': 'not good', -# 'password': 'validPassword!'}) +def test_process_register_returns_400_when_mobile_number_is_invalid(app_, + db_, + db_session, + mock_send_sms, + mock_send_email): + response = app_.test_client().post('/register', + data={'name': 'Bad Mobile', + 'email_address': 'bad_mobile@example.gov.uk', + 'mobile_number': 'not good', + 'password': 'validPassword!'}) -# assert response.status_code == 200 -# assert 'Must be a UK mobile number (eg 07700 900460)' in response.get_data(as_text=True) + assert response.status_code == 200 + assert 'Must be a UK mobile number (eg 07700 900460)' in response.get_data(as_text=True) -# def test_should_return_400_when_email_is_not_gov_uk(app_, -# db_, -# db_session, -# mock_send_sms, -# mock_send_email): -# response = app_.test_client().post('/register', -# data={'name': 'Bad Mobile', -# 'email_address': 'bad_mobile@example.not.right', -# 'mobile_number': '+44123412345', -# 'password': 'validPassword!'}) +def test_should_return_400_when_email_is_not_gov_uk(app_, + db_, + db_session, + mock_send_sms, + mock_send_email): + response = app_.test_client().post('/register', + data={'name': 'Bad Mobile', + 'email_address': 'bad_mobile@example.not.right', + 'mobile_number': '+44123412345', + 'password': 'validPassword!'}) -# assert response.status_code == 200 -# assert 'Enter a gov.uk email address' in response.get_data(as_text=True) + assert response.status_code == 200 + assert 'Enter a gov.uk email address' in response.get_data(as_text=True) -# def test_should_add_verify_codes_on_session(app_, -# db_, -# db_session, -# mock_send_sms, -# mock_send_email, -# mocker): -# user_data = { -# 'name': 'Test Codes', -# 'email_address': 'test@example.gov.uk', -# 'mobile_number': '+4407700900460', -# 'password': 'validPassword!' -# } +def test_should_add_verify_codes_on_session(app_, + db_, + db_session, + mock_send_sms, + mock_send_email, + mocker): + user_data = { + 'name': 'Test Codes', + 'email_address': 'test@example.gov.uk', + 'mobile_number': '+4407700900460', + 'password': 'validPassword!' + } -# mock_register_user(mocker, user_data) -# with app_.test_client() as client: -# response = client.post('/register', -# data=user_data) -# assert response.status_code == 302 -# assert 'notify_admin_session' in response.headers.get('Set-Cookie') + mock_user(mocker, user_data) + with app_.test_client() as client: + response = client.post('/register', + data=user_data) + assert response.status_code == 302 + assert 'notify_admin_session' in response.headers.get('Set-Cookie') -# def test_should_return_400_if_password_is_blacklisted(app_, db_, db_session): -# response = app_.test_client().post('/register', -# data={'name': 'Bad Mobile', -# 'email_address': 'bad_mobile@example.not.right', -# 'mobile_number': '+44123412345', -# 'password': 'password1234'}) +def test_should_return_400_if_password_is_blacklisted(app_, db_, db_session): + response = app_.test_client().post('/register', + data={'name': 'Bad Mobile', + 'email_address': 'bad_mobile@example.not.right', + 'mobile_number': '+44123412345', + 'password': 'password1234'}) -# response.status_code == 200 -# assert 'That password is blacklisted, too common' in response.get_data(as_text=True) + response.status_code == 200 + assert 'That password is blacklisted, too common' in response.get_data(as_text=True)