darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-26 17:24:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #175 from alphagov/fix_cookie_2025_bug

Browse Source 
Fix for bug of cookie expiry.
This commit is contained in:
Chris Hill-Scott
2016-02-15 11:53:20 +00:00
parent 5928c3bb2c 2d4d88f9de
commit 41f09e2934
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/its_dangerous_session.py
View File

@@ -46,7 +46,7 @@ class ItsdangerousSessionInterface(SessionInterface):
domain=domain) domain=domain)
return return
session.permanent = True session.permanent = True
expires = datetime.utcnow() + timedelta(app.config.get('PERMANENT_SESSION_LIFETIME')) expires = datetime.utcnow() + timedelta(seconds=app.config.get('PERMANENT_SESSION_LIFETIME'))
val = self.get_serializer(app).dumps(dict(session)) val = self.get_serializer(app).dumps(dict(session))
response.set_cookie(app.session_cookie_name, val, response.set_cookie(app.session_cookie_name, val,
expires=expires, httponly=True, expires=expires, httponly=True,

1
config.py
View File

@@ -23,6 +23,7 @@ class Config(object):
SESSION_COOKIE_HTTPONLY = True SESSION_COOKIE_HTTPONLY = True
SESSION_COOKIE_SECURE = False SESSION_COOKIE_SECURE = False
PERMANENT_SESSION_LIFETIME = 3600 # seconds PERMANENT_SESSION_LIFETIME = 3600 # seconds
SESSION_REFRESH_EACH_REQUEST = True
API_HOST_NAME = os.getenv('API_HOST_NAME') API_HOST_NAME = os.getenv('API_HOST_NAME')
NOTIFY_API_SECRET = os.getenv('NOTIFY_API_SECRET', "dev-secret") NOTIFY_API_SECRET = os.getenv('NOTIFY_API_SECRET', "dev-secret")