From 40dacdeac999b61a060ac91e4411b689c0c54294 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Wed, 12 Aug 2020 16:33:00 +0100 Subject: [PATCH] Fix live search when selecting broadcast sub areas MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It was targeting the wrong element because it hadn’t been updated to reflect that we’re now using the Design System checkboxes. --- app/templates/views/broadcast/sub-areas.html | 2 +- tests/app/main/views/test_broadcast.py | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/app/templates/views/broadcast/sub-areas.html b/app/templates/views/broadcast/sub-areas.html index 6a9f6dfd9..35cf74fb7 100644 --- a/app/templates/views/broadcast/sub-areas.html +++ b/app/templates/views/broadcast/sub-areas.html @@ -22,7 +22,7 @@ {{ form.select_all }} - {{ live_search(target_selector='.multiple-choice', show=show_search_form, form=search_form, label='Or by electoral ward') }} + {{ live_search(target_selector='.govuk-checkboxes__item', show=show_search_form, form=search_form, label='Or by electoral ward') }} {{ form.areas }} diff --git a/tests/app/main/views/test_broadcast.py b/tests/app/main/views/test_broadcast.py index 2fd779585..4b3f85fe1 100644 --- a/tests/app/main/views/test_broadcast.py +++ b/tests/app/main/views/test_broadcast.py @@ -350,6 +350,9 @@ def test_choose_broadcast_area_page_for_area_with_sub_areas( broadcast_message_id=fake_uuid, library_slug='electoral-wards-of-the-united-kingdom', ) + live_search = page.select_one("[data-module=live-search]") + assert live_search['data-targets'] == '.file-list-item' + assert live_search.select_one('input')['type'] == 'search' partial_url_for = partial( url_for, 'main.choose_broadcast_sub_area', @@ -400,6 +403,9 @@ def test_choose_broadcast_sub_area_page( assert normalize_spaces(page.select_one('h1').text) == ( 'Choose an area of Aberdeen City' ) + live_search = page.select_one("[data-module=live-search]") + assert live_search['data-targets'] == '.govuk-checkboxes__item' + assert live_search.select_one('input')['type'] == 'search' choices = [ ( choice.select_one('input')['value'],