From cffd9417428be3e2f3bb9c7ec298b7e45523960e Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Tue, 12 Apr 2016 16:21:41 +0100 Subject: [PATCH] Fix email expand/collapse not working The click event was scoped to the wrong element. --- app/assets/javascripts/expandCollapse.js | 7 ++----- app/templates/components/email-message.html | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/app/assets/javascripts/expandCollapse.js b/app/assets/javascripts/expandCollapse.js index be1a0ab41..1ae95a5b1 100644 --- a/app/assets/javascripts/expandCollapse.js +++ b/app/assets/javascripts/expandCollapse.js @@ -11,12 +11,9 @@ `) .addClass('collapsed'); - this.$toggle = this.$component.find('.toggle'); - - this.$toggle + this.$toggle = this.$component.find('.toggle') .on( "click", - ".toggle", this.change ) .on("keydown", this.filterKeyPresses([32, 13], this.change)); @@ -34,7 +31,7 @@ this.change = () => this.toggleCollapsed() && this.$toggle.remove(); - this.toggleCollapsed = () => this.$component.toggleClass('collapsed'); + this.toggleCollapsed = () => this.$component.removeClass('collapsed'); }; diff --git a/app/templates/components/email-message.html b/app/templates/components/email-message.html index 616f6e9e1..25b8733fd 100644 --- a/app/templates/components/email-message.html +++ b/app/templates/components/email-message.html @@ -32,7 +32,7 @@ {% endif %}
-