From 35e7260d6f3e39bfd38e70a588f33c0eff88585c Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Mon, 12 Feb 2018 11:39:38 +0000 Subject: [PATCH] Fix bug with disappearing AJAX content in IE 9/10 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We had a user report that the ‘inbound messages’ part of their dashboard was appearing for a split second then disappearing. This was caused by the Javascript on the page throwing an exception as it was trying to re-render this part of the page. This meant it gave up and rendered nothing. The exception was caused by passing `undefined` as the second argument to `.insertBefore`. This is acceptable in most browsers, but not older versions of IE. This is fixed in the latest version of diffDOM (the 3rd party library we use to do the AJAX stuff) by defaulting the second argument to `.insertBefore` to `null`, which is acceptable in old IE versions. See the fix here: https://github.com/fiduswriter/diffDOM/commit/8833d87e9d77d03ab94e792875697ab00712a714 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index a4313825a..cdd49c2c9 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ "dependencies": { "babel-core": "6.26.0", "babel-preset-es2015": "6.24.1", - "diff-dom": "2.3.0", + "diff-dom": "2.3.1", "govuk-elements-sass": "3.1.x", "govuk_frontend_toolkit": "7.2.0", "govuk_template_jinja": "0.23.0",