darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-20 14:29:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix live search on email brand selection

Browse Source 
At some point the element with a `class` of `brand-styles` was removed
from the page, meaning the search stopped working.
This commit is contained in:
Chris Hill-Scott
2018-09-06 12:02:40 +01:00
parent 29f5a86ff6
commit 3ed0cc1437
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/views/service-settings/set-email-branding.html
View File

@@ -17,7 +17,7 @@
</div> </div>
<div class="grid-row"> <div class="grid-row">
<div class="column-full"> <div class="column-full">
{{ live_search(target_selector='.brand_styles .multiple-choice', show=show_search_box, form=search_form, label='Search branding styles by name') }} {{ live_search(target_selector='.multiple-choice', show=show_search_box, form=search_form, label='Search branding styles by name') }}
{{ radios(form.branding_style) }} {{ radios(form.branding_style) }}
</div> </div>
</div> </div>

3
tests/app/main/views/test_service_settings.py
View File

@@ -1926,6 +1926,9 @@ def test_should_show_live_search_if_list_of_brand_styles_taller_than_page(
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser') page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
assert page.select('.live-search') assert page.select('.live-search')
search_target = page.select_one('.live-search')['data-targets']
assert search_target == '.multiple-choice'
assert len(page.select(search_target)) == 9
def test_should_send_branding_and_organisations_to_preview( def test_should_send_branding_and_organisations_to_preview(