darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Group uploaded letters by day of printing

Browse Source 
Some teams have started uploading quite a lot of letters (in the
hundreds per week). They’re also uploading CSVs of emails. This means
the uploads page ends up quite jumbled.

This is because:
- there’s just a lot of items to scan through
- conceptually it’s a bit odd to have batches of things displayed
  alongside individual things on the same page

So instead we’re going to start grouping together uploaded letters. This
will be by the date on which we ‘start’ printing them, or in other
words the time at which they can no longer be cancelled.

This feels like a natural grouping, and it matches what we know about
people’s mental models of ‘batches’ and ‘runs’ when talking about
printing.

This grouping will be done in the API, so all this commit need to do is:
- be ready to display this new type of pseudo-job
- link to the page that displays all the uploaded letters for a given
  print day
This commit is contained in:
Chris Hill-Scott
2020-05-11 10:52:30 +01:00
parent 2800b0a0c3
commit 34f5417844
9 changed files with 115 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
tests/app/test_utils.py
View File

@@ -353,27 +353,27 @@ def test_format_datetime_relative(time, human_readable_datetime):
@pytest.mark.parametrize('utc_datetime', [
'2018-08-01 23:00',
'2018-08-01 16:29',
'2018-11-01 00:00',
'2018-11-01 10:00',
'2018-11-01 17:29',
'2018-08-01T23:00:00+00:00',
'2018-08-01T16:29:00+00:00',
'2018-11-01T00:00:00+00:00',
'2018-11-01T10:00:00+00:00',
'2018-11-01T17:29:00+00:00',
])
def test_printing_today_or_tomorrow_returns_today(utc_datetime):
with freeze_time(utc_datetime):
assert printing_today_or_tomorrow() == 'today'
assert printing_today_or_tomorrow(utc_datetime) == 'today'
@pytest.mark.parametrize('datetime', [
'2018-08-01 22:59',
'2018-08-01 16:30',
'2018-11-01 17:30',
'2018-11-01 21:00',
'2018-11-01 23:59',
@pytest.mark.parametrize('utc_datetime', [
'2018-08-01T22:59:00+00:00',
'2018-08-01T16:30:00+00:00',
'2018-11-01T17:30:00+00:00',
'2018-11-01T21:00:00+00:00',
'2018-11-01T23:59:00+00:00',
])
def test_printing_today_or_tomorrow_returns_tomorrow(datetime):
with freeze_time(datetime):
assert printing_today_or_tomorrow() == 'tomorrow'
def test_printing_today_or_tomorrow_returns_tomorrow(utc_datetime):
with freeze_time(utc_datetime):
assert printing_today_or_tomorrow(utc_datetime) == 'tomorrow'
@pytest.mark.parametrize('created_at, current_datetime', [