darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 15:57:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove platform admin toggles for email/SMS

Browse Source 
Users can do this themselves now.
This commit is contained in:
Chris Hill-Scott
2019-02-01 12:50:59 +00:00
parent 7905b29d64
commit 33f318afec
5 changed files with 0 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/app/main/views/service_settings/test_service_setting_permissions.py
View File

@@ -29,12 +29,6 @@ def get_service_settings_page(
({'research_mode': True}, '.service_switch_research_mode', {}, 'Take service out of research mode'),
({'research_mode': False}, '.service_switch_research_mode', {}, 'Put into research mode'),
({'permissions': ['email']}, '.service_switch_can_send_email', {}, 'Stop sending emails'),
({'permissions': []}, '.service_switch_can_send_email', {}, 'Allow to send emails'),
({'permissions': ['sms']}, '.service_switch_can_send_sms', {}, 'Stop sending sms'),
({'permissions': []}, '.service_switch_can_send_sms', {}, 'Allow to send sms'),
({'permissions': ['letter', 'precompiled_letter']},
'.service_switch_can_send_precompiled_letter', {}, 'Stop sending precompiled letters'),
({'permissions': ['letter']},

30
tests/app/main/views/test_service_settings.py
View File

@@ -1230,36 +1230,6 @@ def test_route_for_platform_admin_update_service(
service_one)
@pytest.mark.parametrize('notification_type, permissions_before_switch, permissions_after_switch', [
('email', [], ['email']),
('email', ['email'], []),
('sms', [], ['sms']),
('sms', ['sms'], [])
])
def test_enabling_and_disabling_email_and_sms(
logged_in_platform_admin_client,
service_one,
mocker,
notification_type,
permissions_before_switch,
permissions_after_switch,
mock_get_inbound_number_for_service
):
service_one['permissions'] = permissions_before_switch
mocked_fn = mocker.patch(
'app.notify_client.service_api_client.service_api_client.update_service',
return_value=service_one,
)
response = logged_in_platform_admin_client.get(
url_for('main.service_switch_can_send_{}'.format(notification_type), service_id=service_one['id'])
)
assert response.status_code == 302
assert response.location == url_for('main.service_settings', service_id=service_one['id'], _external=True)
assert mocked_fn.call_args == call(service_one['id'], permissions=permissions_after_switch)
def test_and_more_hint_appears_on_settings_with_more_than_just_a_single_sender(
client_request,
service_one,