Removed dead code and dead depcrecated route

tests/app/main/views/organizations/test_organization_invites.py

@@ -245,7 +245,7 @@ def test_user_accepts_invite(
     client_request.get(
         "main.accept_org_invite",
         token="thisisnotarealtoken",
-        _expected_redirect=url_for("main.register_from_org_invite"),
+        _expected_redirect=url_for("main.sign_in"),
     )
 
     mock_check_org_invite_token.assert_called_once_with("thisisnotarealtoken")
@@ -253,167 +253,6 @@ def test_user_accepts_invite(
     mock_get_users_for_organization.assert_called_once_with(ORGANISATION_ID)
 
 
-def test_registration_from_org_invite_404s_if_user_not_in_session(
-    client_request, mocker
-):
-    mocker.patch("app.notify_client.user_api_client.UserApiClient.deactivate_user")
-    client_request.logout()
-    client_request.get(
-        "main.register_from_org_invite",
-        _expected_status=404,
-    )
-
-
-@pytest.mark.parametrize(
-    ("data", "error"),
-    [
-        (
-            {
-                "name": "Bad Mobile",
-                "mobile_number": "not good",
-                "password": "validPassword!",  # noqa
-            },
-            "The string supplied did not seem to be a phone number",
-        ),
-        (
-            {
-                "name": "Bad Password",
-                "mobile_number": "+12021234123",
-                "password": "password",  # noqa
-            },
-            "Choose a password that’s harder to guess",
-        ),
-    ],
-)
-def test_registration_from_org_invite_has_bad_data(
-    client_request,
-    sample_org_invite,
-    data,
-    error,
-    mock_get_invited_org_user_by_id,
-    mocker,
-):
-    mocker.patch("app.notify_client.user_api_client.UserApiClient.deactivate_user")
-    client_request.logout()
-
-    with client_request.session_transaction() as session:
-        session["invited_org_user_id"] = sample_org_invite["id"]
-
-    page = client_request.post(
-        "main.register_from_org_invite",
-        _data=data,
-        _expected_status=200,
-    )
-
-    assert error in page.text
-
-
-@pytest.mark.parametrize(
-    "diff_data",
-    [["email_address"], ["organization"], ["email_address", "organization"]],
-)
-def test_registration_from_org_invite_has_different_email_or_organization(
-    client_request,
-    sample_org_invite,
-    diff_data,
-    mock_get_invited_org_user_by_id,
-):
-    client_request.logout()
-    with client_request.session_transaction() as session:
-        session["invited_org_user_id"] = sample_org_invite["id"]
-
-    data = {
-        "name": "Test User",
-        "mobile_number": "+12024900460",
-        "password": "validPassword!",
-        "email_address": sample_org_invite["email_address"],
-        "organization": sample_org_invite["organization"],
-    }
-    for field in diff_data:
-        data[field] = "different"
-
-    client_request.post(
-        "main.register_from_org_invite",
-        _data=data,
-        _expected_status=400,
-    )
-
-
-def test_org_user_registers_with_email_already_in_use(
-    client_request,
-    sample_org_invite,
-    mock_get_user_by_email,
-    mock_accept_org_invite,
-    mock_add_user_to_organization,
-    mock_send_already_registered_email,
-    mock_register_user,
-    mock_get_invited_org_user_by_id,
-):
-    client_request.logout()
-    with client_request.session_transaction() as session:
-        session["invited_org_user_id"] = sample_org_invite["id"]
-
-    client_request.post(
-        "main.register_from_org_invite",
-        _data={
-            "name": "Test User",
-            "mobile_number": "+12024900460",
-            "password": "validPassword!",
-            "email_address": sample_org_invite["email_address"],
-            "organization": sample_org_invite["organization"],
-        },
-        _expected_redirect=url_for("main.verify"),
-    )
-
-    mock_get_user_by_email.assert_called_once_with(sample_org_invite["email_address"])
-    assert mock_register_user.called is False
-    assert mock_send_already_registered_email.called is False
-
-
-def test_org_user_registration(
-    client_request,
-    sample_org_invite,
-    mock_email_is_not_already_in_use,
-    mock_register_user,
-    mock_send_verify_code,
-    mock_get_user_by_email,
-    mock_send_verify_email,
-    mock_accept_org_invite,
-    mock_add_user_to_organization,
-    mock_get_invited_org_user_by_id,
-):
-    client_request.logout()
-    with client_request.session_transaction() as session:
-        session["invited_org_user_id"] = sample_org_invite["id"]
-
-    client_request.post(
-        "main.register_from_org_invite",
-        _data={
-            "name": "Test User",
-            "email_address": sample_org_invite["email_address"],
-            "mobile_number": "+12024900460",
-            "password": "validPassword!",
-            "organization": sample_org_invite["organization"],
-        },
-        _expected_redirect=url_for("main.verify"),
-    )
-
-    assert mock_get_user_by_email.called is False
-    mock_register_user.assert_called_once_with(
-        "Test User",
-        sample_org_invite["email_address"],
-        "+12024900460",
-        "validPassword!",
-        "sms_auth",
-    )
-    mock_send_verify_code.assert_called_once_with(
-        "6ce466d0-fd6a-11e5-82f5-e0accb9d11a6",
-        "sms",
-        "+12024900460",
-    )
-    mock_get_invited_org_user_by_id.assert_called_once_with(sample_org_invite["id"])
-
-
 @pytest.mark.skip("TODO unskip asap")
 def test_verified_org_user_redirects_to_dashboard(
     client_request,

tests/app/test_navigation.py

@@ -152,7 +152,6 @@ EXCLUDED_ENDPOINTS = tuple(
             "received_text_messages_callback",
             "redact_template",
             "register",
-            "register_from_org_invite",
             "registration_continue",
             "remove_user_from_organization",
             "remove_user_from_service",