From 32f0c1127d7c140dbaa1e6ef6330d6fab78a7ba6 Mon Sep 17 00:00:00 2001
From: Chris Hill-Scott <me@quis.cc>
Date: Tue, 19 May 2020 17:47:18 +0100
Subject: [PATCH] Stop posting file_id when sending a letter
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The endpoint works fine with it in the URL now instead, so we need stop
posting it. We can’t stop expecting it yet, because some old instances
will still be posting to the endpoint without the ID in the url.
---
 app/templates/views/uploads/preview.html | 2 +-
 tests/app/main/views/test_uploads.py     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/templates/views/uploads/preview.html b/app/templates/views/uploads/preview.html
index 05e70e5a8..fb11980c9 100644
--- a/app/templates/views/uploads/preview.html
+++ b/app/templates/views/uploads/preview.html
@@ -55,9 +55,9 @@
         <form method="post" enctype="multipart/form-data" action="{{url_for(
             'main.send_uploaded_letter',
             service_id=current_service.id,
+            file_id=file_id,
           )}}" class='page-footer'>
             {{ radios(form.postage, hide_legend=true, inline=True) }}
-            {{ form.file_id(value=file_id) }}
             {{ page_footer("Send 1 letter") }}
         </form>
       {% endif %}
diff --git a/tests/app/main/views/test_uploads.py b/tests/app/main/views/test_uploads.py
index 26845b415..163a6bee2 100644
--- a/tests/app/main/views/test_uploads.py
+++ b/tests/app/main/views/test_uploads.py
@@ -371,7 +371,7 @@ def test_post_upload_letter_redirects_for_valid_file(
     assert page.find('h1').text == 'tests/test_pdf_files/one_page_pdf.pdf'
     assert not page.find(id='validation-error-message')
 
-    assert page.find('input', {'type': 'hidden', 'name': 'file_id', 'value': fake_uuid})
+    assert not page.find('input', {'name': 'file_id'})
     assert normalize_spaces(page.select('main button[type=submit]')[0].text) == 'Send 1 letter'