darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 08:16:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3160 from alphagov/no-min-height-sticky-button

Browse Source 
Remove min-height from sticky submit buttons
This commit is contained in:
Chris Hill-Scott
2019-11-15 12:35:21 +00:00
committed by GitHub
parent 3d9d841eae 4e026bc306
commit 32cc08432c
4 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/assets/stylesheets/components/page-footer.scss
View File

@@ -38,9 +38,17 @@
} }
&-right-aligned-link { &-right-aligned-link {
position: absolute; position: absolute;
right: 0; right: 0;
top: 10px; // align baseline with buttons top: 9px; // align baseline with buttons
&-without-button {
position: absolute;
right: 0;
top: 0;
}
} }
.button, .button,

9
app/assets/stylesheets/components/stick-at-top-when-scrolling.scss
View File

@@ -53,12 +53,7 @@ $sticky-padding: $gutter * 2 / 3;
} }
.page-footer { .page-footer {
margin-bottom: 0; margin-bottom: 1px;
min-height: 50px;
}
.page-footer-delete-link-without-button {
margin-top: 10px;
} }
.notification-status { .notification-status {
@@ -66,7 +61,7 @@ $sticky-padding: $gutter * 2 / 3;
} }
.button-secondary { .button-secondary {
margin-right: $gutter-half; margin: 0 $gutter-half 3px 0;
} }
} }

2
app/templates/views/notifications/check.html
View File

@@ -78,7 +78,7 @@
<button type="submit" class="button">Send 1 {{ message_count_label(1, template.template_type, suffix='') }}</button> <button type="submit" class="button">Send 1 {{ message_count_label(1, template.template_type, suffix='') }}</button>
{% endif %} {% endif %}
{% if template.template_type == 'letter' %} {% if template.template_type == 'letter' %}
<a href="{{ url_for('main.check_notification_preview', service_id=current_service.id, template_id=template.id, filetype='pdf') }}" download class="page-footer-right-aligned-link">Download as a PDF</a> <a href="{{ url_for('main.check_notification_preview', service_id=current_service.id, template_id=template.id, filetype='pdf') }}" download class="page-footer-right-aligned-link{% if error %}-without-button{% endif %}">Download as a PDF</a>
{% endif %} {% endif %}
</form> </form>
</div> </div>

2
app/templates/views/notifications/notification.html
View File

@@ -87,7 +87,7 @@
{% else %} {% else %}
<div>&nbsp;</div> <div>&nbsp;</div>
{% endif %} {% endif %}
<a class="page-footer-right-aligned-link" href="{{ url_for('main.view_letter_notification_as_preview', service_id=current_service.id, notification_id=notification_id, filetype='pdf') }}" download>Download as a PDF</a> <a class="page-footer-right-aligned-link-without-button" href="{{ url_for('main.view_letter_notification_as_preview', service_id=current_service.id, notification_id=notification_id, filetype='pdf') }}" download>Download as a PDF</a>
</div> </div>
</div> </div>
{% elif template.template_type == 'email' %} {% elif template.template_type == 'email' %}