darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-10 18:22:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2762 from alphagov/letter-logo-reword

Browse Source 
Finesse wording on letter branding request page
This commit is contained in:
Chris Hill-Scott
2019-02-13 15:59:02 +00:00
committed by GitHub
parent 82eeb91e79 eae708a1bc
commit 323c0d7ada
2 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/templates/views/service-settings/request-letter-branding.html
+16 -10
View File
@@ -11,17 +11,23 @@
<h1 class="heading-large">Letter branding</h1> <h1 class="heading-large">Letter branding</h1>
<div class="grid-row"> <div class="grid-row">
<div class="column-three-quarters"> <div class="column-three-quarters">
<p> {% if current_service.letter_branding_id %}
{% if current_service.letter_branding_id %} <p>
Your letters have the {{ current_service.letter_branding.name }} logo. Your letters have the {{ current_service.letter_branding.name }} logo.
{% else %} </p>
Your letters have no logo. <p>
{% endif %} <a href="{{ url_for('main.feedback', ticket_type='ask-question-give-feedback', body='letter-branding') }}">Contact support</a>
</p> if you want to use a different logo.
<p> </p>
<a href="{{ url_for('main.feedback', ticket_type='ask-question-give-feedback', body='letter-branding') }}">Contact support</a> {% else %}
if you want to use a different logo. <p>
</p> Your letters do not have a logo.
</p>
<p>
<a href="{{ url_for('main.feedback', ticket_type='ask-question-give-feedback', body='letter-branding') }}">Contact support</a>
if you want to add your organisation’s logo.
</p>
{% endif %}
{% if from_template %} {% if from_template %}
{{ page_footer( {{ page_footer(
back_link=url_for('.view_template', service_id=current_service.id, template_id=from_template), back_link=url_for('.view_template', service_id=current_service.id, template_id=from_template),
tests/app/main/views/test_service_settings.py
+1 -1
View File
@@ -2089,7 +2089,7 @@ def test_request_letter_branding(
service_id=SERVICE_ONE_ID, service_id=SERVICE_ONE_ID,
**extra_args **extra_args
) )
assert request_page.select_one('main p').text.strip() == 'Your letters have no logo.' assert request_page.select_one('main p').text.strip() == 'Your letters do not have a logo.'
link_href = request_page.select_one('main a')['href'] link_href = request_page.select_one('main a')['href']
feedback_page = client_request.get_url(link_href) feedback_page = client_request.get_url(link_href)
assert feedback_page.select_one('textarea').text.strip() == ( assert feedback_page.select_one('textarea').text.strip() == (