darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-19 14:09:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don’t repeat names of columns in the error message

Browse Source 
It makes the error message quite noisy.

We’re going to move the table right underneath the error message, so
you’ll be able to see the column names right there.
This commit is contained in:
Chris Hill-Scott
2017-05-11 11:14:27 +01:00
parent 3bccf39c77
commit 30fe6db2e2
2 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/templates/views/check.html
View File

@@ -81,13 +81,7 @@
your template your template
</h1> </h1>
<p> <p>
Your file has {{ recipients.column_headers | formatted_list( Your file doesn’t have {{ recipients.missing_column_headers | formatted_list(
prefix='one column, called ',
prefix_plural='columns called '
) }}.
</p>
<p>
It doesn’t have {{ recipients.missing_column_headers | formatted_list(
conjunction='or', conjunction='or',
prefix='a column called ', prefix='a column called ',
prefix_plural='columns called ' prefix_plural='columns called '

3
tests/app/main/views/test_send.py
View File

@@ -142,8 +142,7 @@ def test_upload_csvfile_with_errors_shows_check_page_with_errors(
""", """,
( (
'The columns in your file need to match the double brackets in your template ' 'The columns in your file need to match the double brackets in your template '
'Your file has one column, called ‘phone number’. ' 'Your file doesn’t have a column called ‘name’. '
'It doesn’t have a column called ‘name’. '
'Skip to file contents' 'Skip to file contents'
) )
), ),