darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-20 14:29:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1834 from alphagov/button-not-input

Browse Source 
Use `<button>` not `<input>`s for form submission
This commit is contained in:
Chris Hill-Scott
2018-02-02 13:22:36 +00:00
committed by GitHub
parent 2856b8709d 9aa4a7267a
commit 30f89a0041
15 changed files with 18 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/components/banner.html
View File

@@ -13,7 +13,7 @@
{% if delete_button %}
<form method='post'>
<input type="hidden" name="csrf_token" value="{{ csrf_token() }}" />
<input type="submit" class="button" name="delete" value="{{ delete_button }}" />
<button type="submit" class="button" name="delete">{{ delete_button }}</button
</form>
{% endif %}
</div>

2
app/templates/components/file-upload.html
View File

@@ -26,6 +26,6 @@
{% endif %}
<label class="file-upload-filename" for="{{ field.name }}"></label>
<input type="hidden" name="csrf_token" value="{{ csrf_token() }}" />
<input type="submit" class="file-upload-submit" value="Submit" />
<button type="submit" class="file-upload-submit">Submit</button>
</form>
{% endmacro %}

2
app/templates/components/page-footer.html
View File

@@ -11,7 +11,7 @@
<div class="page-footer">
{% if button_text %}
<input type="hidden" name="csrf_token" value="{{ csrf_token() }}" />
<input type="submit" class="button{% if destructive %}-destructive{% endif %}" value="{{ button_text }}" />
<button type="submit" class="button{% if destructive %}-destructive{% endif %}">{{ button_text }}</button>
{% endif %}
{% if back_link %}
<a class="page-footer-back-link" href="{{ back_link }}">{{ back_link_text }}</a>

2
app/templates/views/api/keys.html
View File

@@ -18,7 +18,7 @@
</p>
<form method='post'>
<input type="hidden" name="csrf_token" value="{{ csrf_token() }}" />
<input type="submit" class="button" name="delete" value="Confirm" />
<button type="submit" class="button" name="delete">Confirm</button>
</form>
{% endcall %}
</div>

2
app/templates/views/check/ok.html
View File

@@ -37,7 +37,7 @@
) }}
{% endif %}
{% if template.template_type != 'letter' or not request.args.from_test %}
<input type="submit" class="button" value="Send {{ count_of_recipients }} {{ message_count_label(count_of_recipients, template.template_type, suffix='') }}" />
<button type="submit" class="button">Send {{ count_of_recipients }} {{ message_count_label(count_of_recipients, template.template_type, suffix='') }}</button>
{% else %}
<a href="{{ url_for('main.check_messages_preview', service_id=current_service.id, template_type=template.template_type, upload_id=upload_id, filetype='pdf') }}" download class="button">Download as a printable PDF</a>
{% endif %}

2
app/templates/views/notifications.html
View File

@@ -34,7 +34,7 @@
</div>
<div class="column-one-quarter align-button-with-textbox">
<input type="hidden" name="csrf_token" value="{{ csrf_token() }}">
<input type="submit" class="button" value="Search">
<button type="submit" class="button">Search</button>
</div>
</form>

2
app/templates/views/notifications/check.html
View File

@@ -51,7 +51,7 @@
<input type="hidden" name="csrf_token" value="{{ csrf_token() }}" />
{% if not error %}
{% if template.template_type != 'letter' or not request.args.from_test %}
<input type="submit" class="button" value="Send 1 {{ message_count_label(1, template.template_type, suffix='') }}" />
<button type="submit" class="button">Send 1 {{ message_count_label(1, template.template_type, suffix='') }}</button>
{% else %}
<a href="{{ url_for('main.check_messages_preview', service_id=current_service.id, template_type=template.template_type, upload_id=upload_id, filetype='pdf') }}" download class="button">Download as a printable PDF</a>
{% endif %}

2
app/templates/views/platform-admin/index.html
View File

@@ -22,7 +22,7 @@
{{ textbox(form.end_date, hint="Enter end date in format YYYY-MM-DD") }}
{{ checkbox(form.include_from_test_key) }}
</br>
<input type="submit" class="button">
<button type="submit" class="button">Filter</button>
</form>
</details>

2
app/templates/views/platform-admin/services.html
View File

@@ -107,7 +107,7 @@
{{ textbox(form.end_date, hint="Enter end date in format YYYY-MM-DD") }}
{{ checkbox(form.include_from_test_key) }}
</br>
<input type="submit" class="button">
<button type="submit" class="button">Filter</button>
</form>
</details>

4
app/templates/views/templates/template.html
View File

@@ -23,7 +23,7 @@
</ul>
<form method='post'>
<input type="hidden" name="csrf_token" value="{{ csrf_token() }}" />
<input type="submit" class="button" name="delete" value="Confirm" />
<button type="submit" class="button" name="delete">Confirm</button>
</form>
{% endcall %}
</div>
@@ -37,7 +37,7 @@
{% endif %}
<form method='post'>
<input type="hidden" name="csrf_token" value="{{ csrf_token() }}" />
<input type="submit" class="button" name="delete" value="Confirm" />
<button type="submit" class="button" name="delete">Confirm</button>
</form>
{% endcall %}
</div>