replace user PUT with POSTs

the update_user fn was used in two places, for things that are handled
fine by update_user_attribute. Reduce complexity in the API by killing
the PUT, which is more dangerous (might silently overwrite things that
shouldn't be, like "last_logged_in_at" etc).

Had to change the code not received mobile number form, and the
activate user function.
This commit is contained in:
Leo Hemsted
2017-11-09 12:30:12 +00:00
parent 43b487c823
commit 302a024d3b
7 changed files with 22 additions and 27 deletions

View File

@@ -200,7 +200,7 @@ def test_two_factor_should_activate_pending_user(
mocker,
api_user_pending,
mock_check_verify_code,
mock_update_user,
mock_activate_user,
):
mocker.patch('app.user_api_client.get_user', return_value=api_user_pending)
mocker.patch('app.service_api_client.get_services', return_value={'data': []})
@@ -211,5 +211,5 @@ def test_two_factor_should_activate_pending_user(
}
client.post(url_for('main.two_factor'), data={'sms_code': '12345'})
assert mock_update_user.called
assert mock_activate_user.called
assert api_user_pending.is_active