darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-11 02:23:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

Send api the broadcast provider restriction of 'all', not 'None'

Browse Source 
We're replacing the value of None with the value of all. API has been
updated to accept both values
(https://github.com/alphagov/notifications-api/pull/3233/commits/1767535defd117e1d39d3ab911f01477787eef65)
so this change starts sending notifications-api the value of "all".
This commit is contained in:
Katie Smith
2021-05-10 16:18:14 +01:00
parent a270d631e7
commit 2f9e2dbc9d
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/main/forms.py
+1 -1
View File
@@ -2334,7 +2334,7 @@ class ServiceBroadcastAccountTypeField(GovukRadiosField):
split_values = self.data.split("-") split_values = self.data.split("-")
self.service_mode = split_values[0] self.service_mode = split_values[0]
self.broadcast_channel = split_values[1] self.broadcast_channel = split_values[1]
self.provider_restriction = split_values[2] if len(split_values) == 3 else None self.provider_restriction = split_values[2] if len(split_values) == 3 else 'all'
class ServiceBroadcastAccountTypeForm(StripWhitespaceForm): class ServiceBroadcastAccountTypeForm(StripWhitespaceForm):
tests/app/main/views/test_service_settings.py
+2 -2
View File
@@ -5524,9 +5524,9 @@ def test_get_service_set_broadcast_account_type_has_radio_selected_for_broadcast
@pytest.mark.parametrize( @pytest.mark.parametrize(
'value,service_mode,broadcast_channel,allowed_broadcast_provider', 'value,service_mode,broadcast_channel,allowed_broadcast_provider',
[ [
("training-test", "training", "test", None), ("training-test", "training", "test", "all"),
("live-test-vodafone", "live", "test", "vodafone"), ("live-test-vodafone", "live", "test", "vodafone"),
("live-severe", "live", "severe", None), ("live-severe", "live", "severe", "all"),
] ]
) )
def test_post_service_set_broadcast_account_type_posts_data_to_api_and_redirects( def test_post_service_set_broadcast_account_type_posts_data_to_api_and_redirects(