darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-04 05:31:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3528 from alphagov/fix-set-broadcast-permission

Browse Source 
Fix setting of broadcast permission
This commit is contained in:
Chris Hill-Scott
2020-07-17 10:40:26 +01:00
committed by GitHub
parent a1f063c9aa e29a477eb1
commit 2d7d800c64
3 changed files with 64 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/main/views/service_settings.py
View File

@@ -318,10 +318,7 @@ def service_set_broadcast_permission(service_id):
if form.validate_on_submit():
if form.enabled.data:
current_service.force_permission('broadcast', on=True)
current_service.force_permission('email', on=False)
current_service.force_permission('sms', on=False)
current_service.force_permission('letter', on=False)
current_service.force_broadcast_permission_on()
else:
current_service.force_permission('broadcast', on=False)

5
app/models/service.py
View File

@@ -99,6 +99,11 @@ class Service(JSONModel):
permissions | permission if on else permissions - permission,
)
def force_broadcast_permission_on(self):
return self.update_permissions(
set(self.permissions) - {'email', 'sms', 'letter'} | {'broadcast'}
)
def update_permissions(self, permissions):
return self.update(permissions=list(permissions))