From 2d5a165a2dec2bedfb2f7da0cbe64edab0a702e6 Mon Sep 17 00:00:00 2001 From: Tom Byers Date: Tue, 27 Oct 2020 17:03:01 +0000 Subject: [PATCH] Swap headings for list items in template list I'm mainly making this change because it's useful for the CSS that styles the hint text when the link is focused for the link to have no parent container. That being said, there isn't really enough content underneath these headings to justify them as it is. I've wrapped them in a list instead because: - they're structured like a list - we already called them a `template-list` This commit also replaces the `message-type` class on the paragraph below where the headings went, for consistency. It also removes the CSS for that class as I couldn't find anywhere else that used it now. --- .../stylesheets/components/message.scss | 8 --- .../views/templates/_template_list.html | 18 ++++--- .../views/templates/choose-reply.html | 38 +++++++------- app/templates/views/templates/copy.html | 50 +++++++++---------- tests/app/main/views/test_templates.py | 2 +- 5 files changed, 57 insertions(+), 59 deletions(-) diff --git a/app/assets/stylesheets/components/message.scss b/app/assets/stylesheets/components/message.scss index d04a7dfa9..21f0897fc 100644 --- a/app/assets/stylesheets/components/message.scss +++ b/app/assets/stylesheets/components/message.scss @@ -56,14 +56,6 @@ $message-type-bottom-spacing: govuk-spacing(4); } - &-type { - position: relative; /* needs to be non-static to have a z-index above the link :before element */ - color: $govuk-secondary-text-colour; - margin: 0 0 $message-type-bottom-spacing 0; - padding-left: 0; - pointer-events: none; - } - } .template-list { diff --git a/app/templates/views/templates/_template_list.html b/app/templates/views/templates/_template_list.html index 0b30b18a1..2d4a4f849 100644 --- a/app/templates/views/templates/_template_list.html +++ b/app/templates/views/templates/_template_list.html @@ -26,6 +26,10 @@