All tests passing and merged with master.

This commit is contained in:
Nicholas Staples
2016-01-27 16:30:33 +00:00
51 changed files with 763 additions and 892 deletions

View File

@@ -1,9 +1,9 @@
from datetime import datetime
from app.main.dao import users_dao
from flask import url_for
import pytest
from flask import url_for
def test_render_sign_in_returns_sign_in_template(app_):
@@ -16,11 +16,26 @@ def test_render_sign_in_returns_sign_in_template(app_):
assert 'Forgotten password?' in response.get_data(as_text=True)
def test_logged_in_user_redirects_to_choose_service(app_,
api_user_active,
mock_get_user_by_email,
mock_login):
with app_.test_request_context():
with app_.test_client() as client:
client.login(api_user_active)
response = client.get(url_for('main.sign_in'))
assert response.status_code == 302
response = client.get(url_for('main.sign_in', follow_redirects=True))
assert response.location == url_for('main.choose_service', _external=True)
def test_process_sign_in_return_2fa_template(app_,
mock_send_verify_code,
mock_get_user,
mock_get_user_by_email,
mock_verify_password):
with app_.test_request_context():
response = app_.test_client().post(
url_for('main.sign_in'), data={
@@ -30,72 +45,44 @@ def test_process_sign_in_return_2fa_template(app_,
assert response.location == 'http://localhost/two-factor'
@pytest.mark.xfail(reason='User failed logins not implemented yet')
def test_should_return_locked_out_true_when_user_is_locked(app_,
mock_user_dao_get_user,
mock_inactive_user_dao_get_by_email):
mock_get_user_by_email_locked):
with app_.test_request_context():
for _ in range(10):
app_.test_client().post(
url_for('main.sign_in'), data={
'email_address': 'valid@example.gov.uk',
'password': 'whatIsMyPassword!'})
response = app_.test_client().post(
url_for('main.sign_in'), data={
'email_address': 'valid@example.gov.uk',
'password': 'val1dPassw0rd!'})
assert response.status_code == 200
assert 'Username or password is incorrect' in response.get_data(as_text=True)
another_bad_attempt = app_.test_client().post(
resp = app_.test_client().post(
url_for('main.sign_in'), data={
'email_address': 'valid@example.gov.uk',
'password': 'whatIsMyPassword!'})
assert another_bad_attempt.status_code == 200
assert 'Username or password is incorrect' in response.get_data(as_text=True)
assert resp.status_code == 200
assert 'Username or password is incorrect' in resp.get_data(as_text=True)
# @pytest.mark.xfail(reason='User failed logins not implemented yet')
# def test_should_return_active_user_is_false_if_user_is_inactive(app_,
# mock_user_dao_get_user,
# mock_inactive_user_dao_get_by_email):
# with app_.test_request_context():
# response = app_.test_client().post(
# url_for('main.sign_in'), data={
# 'email_address': 'inactive_user@example.gov.uk',
# 'password': 'val1dPassw0rd!'})
def test_should_return_active_user_is_false_if_user_is_inactive(app_, mock_get_user_by_email_inactive):
# assert response.status_code == 200
# assert 'Username or password is incorrect' in response.get_data(as_text=True)
with app_.test_request_context():
response = app_.test_client().post(
url_for('main.sign_in'), data={
'email_address': 'inactive_user@example.gov.uk',
'password': 'val1dPassw0rd!'})
assert response.status_code == 200
assert 'Username or password is incorrect' in response.get_data(as_text=True)
# def test_should_return_200_when_user_does_not_exist(app_,
# mock_user_dao_get_user,
# mock_user_dao_get_by_email):
# with app_.test_request_context():
# response = app_.test_client().post(
# url_for('main.sign_in'), data={
# 'email_address': 'does_not_exist@gov.uk',
# 'password': 'doesNotExist!'})
# assert response.status_code == 200
# assert 'Username or password is incorrect' in response.get_data(as_text=True)
def test_should_return_200_when_user_does_not_exist(app_, mock_get_user_by_email_not_found):
with app_.test_request_context():
response = app_.test_client().post(
url_for('main.sign_in'), data={
'email_address': 'notfound@gov.uk',
'password': 'doesNotExist!'})
assert response.status_code == 200
assert 'Username or password is incorrect' in response.get_data(as_text=True)
# def test_should_return_200_when_user_is_not_active(app_):
# user = User(email_address='PendingUser@example.gov.uk',
# password='val1dPassw0rd!',
# mobile_number='+441234123123',
# name='pending user',
# created_at=datetime.now(),
# role_id=1,
# state='pending')
# users_dao.insert_user(user)
# with app_.test_request_context():
# response = app_.test_client().post(
# url_for('main.sign_in'), data={
# 'email_address': 'PendingUser@example.gov.uk',
# 'password': 'val1dPassw0rd!'})
# assert response.status_code == 200
# assert 'Username or password is incorrect' in response.get_data(as_text=True)
def test_should_return_200_when_user_is_pending(app_, mock_get_user_by_email_pending):
with app_.test_request_context():
response = app_.test_client().post(
url_for('main.sign_in'), data={
'email_address': 'pending_user@example.gov.uk',
'password': 'val1dPassw0rd!'})
assert response.status_code == 200
assert 'Username or password is incorrect' in response.get_data(as_text=True)