darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-25 00:33:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

All tests passing and merged with master.

Browse Source
This commit is contained in:
Nicholas Staples
2016-01-27 16:30:33 +00:00
parent 6959d695d3 68891d8eb8
commit 2d35f5f36a
51 changed files with 763 additions and 892 deletions
Download Patch File Download Diff File Expand all files Collapse all files

86
tests/app/main/views/test_register.py
View File

@@ -1,43 +1,58 @@
from flask import url_for
from tests.conftest import mock_register_user as mock_user
def test_render_register_returns_template_with_form(app_):
response = app_.test_client().get('/register')
assert response.status_code == 200
assert 'Create an account' in response.get_data(as_text=True)
# def test_render_register_returns_template_with_form(app_, db_, db_session):
# response = app_.test_client().get('/register')
def test_logged_in_user_redirects_to_choose_service(app_,
api_user_active,
mock_get_user_by_email,
mock_send_verify_code,
mock_login):
with app_.test_request_context():
with app_.test_client() as client:
client.login(api_user_active)
response = client.get(url_for('main.register'))
assert response.status_code == 302
# assert response.status_code == 200
# assert 'Create an account' in response.get_data(as_text=True)
response = client.get(url_for('main.sign_in', follow_redirects=True))
assert response.location == url_for('main.choose_service', _external=True)
def test_process_register_creates_new_user(app_,
mock_send_verify_code,
mock_register_user,
mock_user_by_email_not_found,
mock_get_user_by_email_not_found,
mock_login):
user_data = {
'name': 'Some One Valid',
'email_address': 'someone@example.gov.uk',
'email_address': 'notfound@example.gov.uk',
'mobile_number': '+4407700900460',
'password': 'validPassword!'
}
with app_.test_request_context():
response = app_.test_client().post('/register',
response = app_.test_client().post(url_for('main.register'),
data=user_data)
assert response.status_code == 302
assert response.location == url_for('main.verify', _external=True)
assert mock_register_user.called
def test_process_register_returns_400_when_mobile_number_is_invalid(app_,
mock_send_verify_code,
mock_user_by_email_not_found,
mock_get_user_by_email_not_found,
mock_login):
response = app_.test_client().post('/register',
data={'name': 'Bad Mobile',
'email_address': 'bad_mobile@example.gov.uk',
'mobile_number': 'not good',
'password': 'validPassword!'})
with app_.test_request_context():
response = app_.test_client().post(url_for('main.register'),
data={'name': 'Bad Mobile',
'email_address': 'bad_mobile@example.gov.uk',
'mobile_number': 'not good',
'password': 'validPassword!'})
assert response.status_code == 200
assert 'Must be a UK mobile number (eg 07700 900460)' in response.get_data(as_text=True)
@@ -45,13 +60,14 @@ def test_process_register_returns_400_when_mobile_number_is_invalid(app_,
def test_should_return_400_when_email_is_not_gov_uk(app_,
mock_send_verify_code,
mock_user_by_email_not_found,
mock_get_user_by_email,
mock_login):
response = app_.test_client().post('/register',
data={'name': 'Bad Mobile',
'email_address': 'bad_mobile@example.not.right',
'mobile_number': '+44123412345',
'password': 'validPassword!'})
with app_.test_request_context():
response = app_.test_client().post(url_for('main.register'),
data={'name': 'Bad Mobile',
'email_address': 'bad_mobile@example.not.right',
'mobile_number': '+44123412345',
'password': 'validPassword!'})
assert response.status_code == 200
assert 'Enter a gov.uk email address' in response.get_data(as_text=True)
@@ -60,31 +76,33 @@ def test_should_return_400_when_email_is_not_gov_uk(app_,
def test_should_add_verify_codes_on_session(app_,
mock_send_verify_code,
mock_register_user,
mock_user_loader,
mock_user_by_email_not_found,
mock_get_user,
mock_get_user_by_email_not_found,
mock_login):
user_data = {
'name': 'Test Codes',
'email_address': 'test@example.gov.uk',
'email_address': 'notfound@example.gov.uk',
'mobile_number': '+4407700900460',
'password': 'validPassword!'
}
with app_.test_client() as client:
response = client.post('/register',
data=user_data)
assert response.status_code == 302
assert 'notify_admin_session' in response.headers.get('Set-Cookie')
with app_.test_request_context():
with app_.test_client() as client:
response = client.post(url_for('main.register'),
data=user_data)
assert response.status_code == 302
assert 'notify_admin_session' in response.headers.get('Set-Cookie')
def test_should_return_400_if_password_is_blacklisted(app_,
mock_user_by_email_not_found,
mock_get_user_by_email,
mock_login):
response = app_.test_client().post('/register',
data={'name': 'Bad Mobile',
'email_address': 'bad_mobile@example.not.right',
'mobile_number': '+44123412345',
'password': 'password1234'})
with app_.test_request_context():
response = app_.test_client().post(url_for('main.register'),
data={'name': 'Bad Mobile',
'email_address': 'bad_mobile@example.not.right',
'mobile_number': '+44123412345',
'password': 'password1234'})
response.status_code == 200
assert 'That password is blacklisted, too common' in response.get_data(as_text=True)