changed guidanced to best practices

app/config.py

@@ -87,7 +87,7 @@ class Config(object):
             "tts-benefits-studio@gsa.gov",
         ],
     }
-    FEATURE_GUIDANCE_ENABLED = getenv("FEATURE_GUIDANCE_ENABLED", "false")
+    FEATURE_BEST_PRACTICES_ENABLED = getenv("FEATURE_BEST_PRACTICES_ENABLED", "false")
 
 
 def _s3_credentials_from_env(bucket_prefix):

deploy-config/demo.yml

@@ -7,4 +7,4 @@ cloud_dot_gov_route: notify-demo.app.cloud.gov
 redis_enabled: 1
 nr_agent_id: '1134302465'
 nr_app_id: '1083160688'
-FEATURE_GUIDANCE_ENABLED: true
+FEATURE_BEST_PRACTICES_ENABLED: true

deploy-config/production.yml

@@ -7,4 +7,4 @@ cloud_dot_gov_route: notify.app.cloud.gov
 redis_enabled: 1
 nr_agent_id: '1050708682'
 nr_app_id: '1050708682'
-FEATURE_GUIDANCE_ENABLED: false
+FEATURE_BEST_PRACTICES_ENABLED: false

deploy-config/sandbox.yml

@@ -12,4 +12,4 @@ SECRET_KEY: sandbox-notify-secret-key
 nr_agent_id: ''
 nr_app_id: ''
 NR_BROWSER_KEY: ''
-FEATURE_GUIDANCE_ENABLED: true
+FEATURE_BEST_PRACTICES_ENABLED: true

deploy-config/staging.yml

@@ -7,4 +7,4 @@ cloud_dot_gov_route: notify-staging.app.cloud.gov
 redis_enabled: 1
 nr_agent_id: '1134291385'
 nr_app_id: '1031640326'
-FEATURE_GUIDANCE_ENABLED: false
+FEATURE_BEST_PRACTICES_ENABLED: false

docs/feature-flagging.md

@@ -34,7 +34,7 @@ cf set-env <APP_NAME> <ENV_VAR_NAME> <VALUE>
 #### Example:
 
 ```
-cf set-env notify-admin-sandbox FEATURE_GUIDANCE_ENABLED true
+cf set-env notify-admin-sandbox FEATURE_BEST_PRACTICES_ENABLED true
 ```
 
 ### 4. Restage the Application

manifest.yml

@@ -62,4 +62,4 @@ applications:
       LOGIN_DOT_GOV_CERTS_URL: ((LOGIN_DOT_GOV_CERTS_URL))
 
       # feature flagging
-      FEATURE_GUIDANCE_ENABLED: ((FEATURE_GUIDANCE_ENABLED))
+      FEATURE_BEST_PRACTICES_ENABLED: ((FEATURE_BEST_PRACTICES_ENABLED))

tests/app/main/views/test_index.py

@@ -13,7 +13,7 @@ from flask import url_for
         "roadmap",
         "features",
         "documentation",
-        "guidance",
+        "best_practices",
         "clear_goals",
         "rules_and_regulations",
         "establish_trust",
@@ -37,11 +37,11 @@ def test_static_pages(client_request, mock_get_organization_by_domain, view, moc
 
     # Function to check if a view is feature-flagged and should return 404 when disabled
     def is_feature_flagged(view):
-        feature_guidance_enabled = (
-            os.getenv("FEATURE_GUIDANCE_ENABLED", "false").lower() == "true"
+        feature_best_practices_enabled = (
+            os.getenv("FEATURE_BEST_PRACTICES_ENABLED", "false").lower() == "true"
         )
         feature_flagged_views = [
-            "guidance",
+            "best_practices",
             "clear_goals",
             "rules_and_regulations",
             "establish_trust",
@@ -49,7 +49,7 @@ def test_static_pages(client_request, mock_get_organization_by_domain, view, moc
             "multiple_languages",
             "benchmark_performance",
         ]
-        return not feature_guidance_enabled and view in feature_flagged_views
+        return not feature_best_practices_enabled and view in feature_flagged_views
 
     request = partial(client_request.get, "main.{}".format(view))
 

urls.js

@@ -13,13 +13,13 @@ const sublinks = [
   { label: 'Roadmap', path: '/features/roadmap' },
   { label: 'Security', path: '/features/security' },
   { label: 'Support', path: '/support' },
-  { label: 'Guidance', path: '/guidance' },
-  { label: 'Clear Goals', path: '/guidance/clear-goals' },
-  { label: 'Rules And Regulations', path: '/guidance/rules-and-regulations' },
-  { label: 'Establish Trust', path: '/guidance/establish-trust' },
-  { label: 'Write For Action', path: '/guidance/write-for-action' },
-  { label: 'Multiple Languages', path: '/guidance/multiple-languages' },
-  { label: 'Benchmark Performance', path: '/guidance/benchmark-performance' },
+  { label: 'Best Practices', path: '/best-practices' },
+  { label: 'Clear Goals', path: '/best-practices/clear-goals' },
+  { label: 'Rules And Regulations', path: '/best-practices/rules-and-regulations' },
+  { label: 'Establish Trust', path: '/best-practices/establish-trust' },
+  { label: 'Write For Action', path: '/best-practices/write-for-action' },
+  { label: 'Multiple Languages', path: '/best-practices/multiple-languages' },
+  { label: 'Benchmark Performance', path: '/best-practices/benchmark-performance' },
   // Add more links here as needed
 ];