darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-07 15:18:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2315 from alphagov/3-becomes-4

Browse Source 
Set min text message sender length to 4 characters
This commit is contained in:
Chris Hill-Scott
2018-09-19 16:57:27 +01:00
committed by GitHub
parent 0edc569247 36eac9d031
commit 2b8da4a2fa
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/main/forms.py
View File

@@ -644,7 +644,7 @@ class ServiceSmsSenderForm(StripWhitespaceForm):
validators=[ validators=[
DataRequired(message="Can’t be empty"), DataRequired(message="Can’t be empty"),
Length(max=11, message="Enter 11 characters or fewer"), Length(max=11, message="Enter 11 characters or fewer"),
Length(min=3, message="Enter 3 characters or more"), Length(min=4, message="Enter 4 characters or more"),
LettersNumbersAndFullStopsOnly(), LettersNumbersAndFullStopsOnly(),
DoesNotStartWithDoubleZero(), DoesNotStartWithDoubleZero(),
] ]

6
tests/app/main/test_validators.py
View File

@@ -214,11 +214,11 @@ def test_sms_sender_form_validation(
form.validate() form.validate()
assert 'Use letters and numbers only' == form.errors['sms_sender'][0] assert 'Use letters and numbers only' == form.errors['sms_sender'][0]
form.sms_sender.data = '0' form.sms_sender.data = '333'
form.validate() form.validate()
assert 'Enter 3 characters or more' == form.errors['sms_sender'][0] assert 'Enter 4 characters or more' == form.errors['sms_sender'][0]
form.sms_sender.data = '111' form.sms_sender.data = '4444'
form.validate() form.validate()
assert not form.errors assert not form.errors