darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-16 20:49:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Replace UK phone numbers in tests with US numbers

Browse Source
This commit is contained in:
Ryan Ahearn
2022-12-22 22:11:07 -05:00
parent cc142666d5
commit 2ad21a6f4f
35 changed files with 483 additions and 478 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/app/main/forms/test_placeholder_form.py
View File

@@ -28,9 +28,9 @@ def test_form_class_not_mutated(notify_admin):
(False, 'email address', 'email', 'test@example.gsa.gov', None),
(False, 'phone number', 'sms', '', 'Cannot be empty'),
(False, 'phone number', 'sms', '+1-2345-678890', 'Not a UK mobile number'),
(False, 'phone number', 'sms', '07900900123', None),
(False, 'phone number', 'sms', '+44(0)7900 900-123', None),
(False, 'phone number', 'sms', '+(44) 7700-900 855', 'Not a US number'),
(False, 'phone number', 'sms', '2028675309', None),
(False, 'phone number', 'sms', '+1 (202) 867-5309', None),
(True, 'phone number', 'sms', '+123', 'Not enough digits'),
(True, 'phone number', 'sms', '+44(0)7900 900-123', None),
@@ -39,7 +39,7 @@ def test_form_class_not_mutated(notify_admin):
(False, 'anything else', 'sms', '', 'Cannot be empty'),
(False, 'anything else', 'email', '', 'Cannot be empty'),
(True, 'phone number', 'sms', 'invalid', 'Must not contain letters or symbols'),
(True, 'phone number', 'sms', 'invalid', 'The string supplied did not seem to be a phone number.'),
(True, 'phone number', 'email', 'invalid', None),
(True, 'email address', 'sms', 'invalid', None),

10
tests/app/main/forms/test_register_user_form.py
View File

@@ -14,7 +14,7 @@ def test_should_raise_validation_error_for_password(
form = RegisterUserForm()
form.name.data = 'test'
form.email_address.data = 'teset@gsa.gov'
form.mobile_number.data = '441231231231'
form.mobile_number.data = '2021231231'
form.password.data = password
form.validate()
@@ -25,7 +25,7 @@ def test_valid_email_not_in_valid_domains(
client_request,
mock_get_organisations,
):
form = RegisterUserForm(email_address="test@test.com", mobile_number='441231231231')
form = RegisterUserForm(email_address="test@test.com", mobile_number='2021231231')
assert not form.validate()
assert "Enter a public sector email address" in form.errors['email_address'][0]
@@ -36,7 +36,7 @@ def test_valid_email_in_valid_domains(
form = RegisterUserForm(
name="test",
email_address="test@gsa.gov",
mobile_number='4407888999111',
mobile_number='2028675309',
password='an uncommon password')
form.validate()
assert form.errors == {}
@@ -49,13 +49,13 @@ def test_invalid_email_address_error_message(
form = RegisterUserForm(
name="test",
email_address="test.com",
mobile_number='4407888999111',
mobile_number='2028675309',
password='1234567890')
assert not form.validate()
form = RegisterUserForm(
name="test",
email_address="test.com",
mobile_number='4407888999111',
mobile_number='+12028675309',
password='1234567890')
assert not form.validate()

6
tests/app/main/forms/test_service_contact_details_form.py
View File

@@ -17,8 +17,8 @@ def test_form_fails_validation_with_no_radio_buttons_selected(notify_admin):
('phone_number', 'url', 'http://www.example.com'),
('url', 'email_address', 'user@example.com'),
('phone_number', 'email_address', 'user@example.com'),
('url', 'phone_number', '0207 123 4567'),
('email_address', 'phone_number', '0207 123 4567'),
('url', 'phone_number', '202 867 5309'),
('email_address', 'phone_number', '202 867 5309'),
])
def test_form_fails_validation_when_radio_button_selected_and_text_box_filled_in_do_not_match(
notify_admin,
@@ -39,7 +39,7 @@ def test_form_fails_validation_when_radio_button_selected_and_text_box_filled_in
@pytest.mark.parametrize('selected_field, url, email_address, phone_number', [
('url', 'http://www.example.com', 'invalid-email.com', 'phone'),
('email_address', 'www.invalid-url.com', 'me@example.com', 'phone'),
('phone_number', 'www.invalid-url.com', 'invalid-email.com', '0207 123 4567'),
('phone_number', 'www.invalid-url.com', 'invalid-email.com', '202 867 5309'),
])
def test_form_only_validates_the_field_which_matches_the_selected_radio_button(
notify_admin,