darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-18 13:39:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

remove carrier column

Browse Source
This commit is contained in:
Kenneth Kehl
2024-02-09 07:27:28 -08:00
parent 2962fc36c4
commit 2aa9f2c532
2 changed files with 4 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/utils/csv.py
View File

@@ -83,7 +83,6 @@ def generate_notifications_csv(**kwargs):
"Type", "Type",
"Sent by", "Sent by",
"Job", "Job",
"Carrier",
"Carrier Response", "Carrier Response",
"Status", "Status",
"Time", "Time",
@@ -99,7 +98,6 @@ def generate_notifications_csv(**kwargs):
"Type", "Type",
"Sent by", "Sent by",
"Job", "Job",
"Carrier",
"Carrier Response", "Carrier Response",
"Status", "Status",
"Time", "Time",
@@ -124,7 +122,6 @@ def generate_notifications_csv(**kwargs):
notification["template_type"], notification["template_type"],
notification["created_by_name"], notification["created_by_name"],
notification["job_name"], notification["job_name"],
notification["carrier"],
notification["provider_response"], notification["provider_response"],
notification["status"], notification["status"],
preferred_tz_created_at, preferred_tz_created_at,
@@ -142,7 +139,6 @@ def generate_notifications_csv(**kwargs):
notification["template_type"], notification["template_type"],
notification["created_by_name"] or "", notification["created_by_name"] or "",
notification["job_name"] or "", notification["job_name"] or "",
notification["carrier"],
notification["provider_response"], notification["provider_response"],
notification["status"], notification["status"],
preferred_tz_created_at, preferred_tz_created_at,

16
tests/app/utils/test_csv.py
View File

@@ -18,7 +18,6 @@ def _get_notifications_csv(
template_name="foo", template_name="foo",
template_type="sms", template_type="sms",
job_name="bar.csv", job_name="bar.csv",
carrier="ATT Mobility",
provider_response="Did not like it", provider_response="Did not like it",
status="Delivered", status="Delivered",
created_at="1943-04-19 12:00:00", created_at="1943-04-19 12:00:00",
@@ -50,7 +49,6 @@ def _get_notifications_csv(
"template_type": template_type, "template_type": template_type,
"template": {"name": template_name, "template_type": template_type}, "template": {"name": template_name, "template_type": template_type},
"job_name": job_name, "job_name": job_name,
"carrier": carrier,
"provider_response": provider_response, "provider_response": provider_response,
"status": status, "status": status,
"created_at": created_at, "created_at": created_at,
@@ -90,15 +88,15 @@ def get_notifications_csv_mock(
( (
None, None,
[ [
"Recipient,Template,Type,Sent by,Job,Carrier,Carrier Response,Status,Time\n", "Recipient,Template,Type,Sent by,Job,Carrier Response,Status,Time\n",
"foo@bar.com,foo,sms,,,ATT Mobility,Did not like it,Delivered,1943-04-19 08:00:00 AM US/Eastern\r\n", "foo@bar.com,foo,sms,,,Did not like it,Delivered,1943-04-19 08:00:00 AM US/Eastern\r\n",
], ],
), ),
( (
"Anne Example", "Anne Example",
[ [
"Recipient,Template,Type,Sent by,Job,Carrier,Carrier Response,Status,Time\n", "Recipient,Template,Type,Sent by,Job,Carrier Response,Status,Time\n",
"foo@bar.com,foo,sms,Anne Example,,ATT Mobility,Did not like it,Delivered,1943-04-19 08:00:00 AM US/Eastern\r\n", # noqa "foo@bar.com,foo,sms,Anne Example,,Did not like it,Delivered,1943-04-19 08:00:00 AM US/Eastern\r\n", # noqa
], ],
), ),
], ],
@@ -134,7 +132,6 @@ def test_generate_notifications_csv_without_job(
"Type", "Type",
"Sent by", "Sent by",
"Job", "Job",
"Carrier",
"Carrier Response", "Carrier Response",
"Status", "Status",
"Time", "Time",
@@ -145,7 +142,6 @@ def test_generate_notifications_csv_without_job(
"sms", "sms",
"Fake Person", "Fake Person",
"bar.csv", "bar.csv",
"ATT Mobility",
"Did not like it", "Did not like it",
"Delivered", "Delivered",
"1943-04-19 08:00:00 AM US/Eastern", "1943-04-19 08:00:00 AM US/Eastern",
@@ -162,7 +158,6 @@ def test_generate_notifications_csv_without_job(
"Type", "Type",
"Sent by", "Sent by",
"Job", "Job",
"Carrier",
"Carrier Response", "Carrier Response",
"Status", "Status",
"Time", "Time",
@@ -176,7 +171,6 @@ def test_generate_notifications_csv_without_job(
"sms", "sms",
"Fake Person", "Fake Person",
"bar.csv", "bar.csv",
"ATT Mobility",
"Did not like it", "Did not like it",
"Delivered", "Delivered",
"1943-04-19 08:00:00 AM US/Eastern", "1943-04-19 08:00:00 AM US/Eastern",
@@ -196,7 +190,6 @@ def test_generate_notifications_csv_without_job(
"Type", "Type",
"Sent by", "Sent by",
"Job", "Job",
"Carrier",
"Carrier Response", "Carrier Response",
"Status", "Status",
"Time", "Time",
@@ -210,7 +203,6 @@ def test_generate_notifications_csv_without_job(
"sms", "sms",
"Fake Person", "Fake Person",
"bar.csv", "bar.csv",
"ATT Mobility",
"Did not like it", "Did not like it",
"Delivered", "Delivered",
"1943-04-19 08:00:00 AM US/Eastern", "1943-04-19 08:00:00 AM US/Eastern",