From 11a85d688a170e89919cec767fc4424ddd35e95c Mon Sep 17 00:00:00 2001 From: Beverly Nguyen Date: Mon, 15 Jan 2024 14:17:18 -0800 Subject: [PATCH 1/3] added notifications status --- app/templates/views/jobs/job.html | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/templates/views/jobs/job.html b/app/templates/views/jobs/job.html index 6001ae3b6..0c334a634 100644 --- a/app/templates/views/jobs/job.html +++ b/app/templates/views/jobs/job.html @@ -38,6 +38,9 @@ {% endif %} +

+ Messages will remain in pending state until carrier status is received, typically 5 minutes. +

{% if not job.processing_finished %}
Date: Tue, 16 Jan 2024 11:28:58 -0800 Subject: [PATCH 2/3] update testing --- tests/app/main/views/test_jobs.py | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/tests/app/main/views/test_jobs.py b/tests/app/main/views/test_jobs.py index cc611f32b..8a18a7693 100644 --- a/tests/app/main/views/test_jobs.py +++ b/tests/app/main/views/test_jobs.py @@ -349,9 +349,14 @@ def test_should_show_scheduled_job( job_id=fake_uuid, ) - assert normalize_spaces(page.select("main p")[1].text) == ( + assert normalize_spaces(page.select("main div p")[1].text) == ( "Sending Two week reminder today at 00:00 US/Eastern" ) + + # assert normalize_spaces(page.select_one("main p.notification-status").text) == ( + # "Messages will remain in pending state until carrier status is received, typically 5 minutes." + # ) + assert page.select("main p a")[0]["href"] == url_for( "main.view_template_version", service_id=SERVICE_ONE_ID, @@ -481,3 +486,21 @@ def test_should_show_updates_for_scheduled_job_as_json( @freeze_time("2016-01-10 12:00:00.000000") def test_time_left(job_created_at, expected_message): assert get_time_left(job_created_at) == expected_message + +def test_should_show_message_note( + client_request, + mock_get_service_template, + mock_get_scheduled_job, + mock_get_service_data_retention, + mock_get_notifications, + fake_uuid, +): + page = client_request.get( + "main.view_job", + service_id=SERVICE_ONE_ID, + job_id=fake_uuid, + ) + + assert normalize_spaces(page.select_one("main p.notification-status").text) == ( + "Messages will remain in pending state until carrier status is received, typically 5 minutes." + ) From 25305d07060a69cdbef72eca2c22126d210613d7 Mon Sep 17 00:00:00 2001 From: Beverly Nguyen Date: Tue, 16 Jan 2024 12:01:39 -0800 Subject: [PATCH 3/3] update testing --- tests/app/main/views/test_jobs.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/app/main/views/test_jobs.py b/tests/app/main/views/test_jobs.py index 8a18a7693..42cd5ecbf 100644 --- a/tests/app/main/views/test_jobs.py +++ b/tests/app/main/views/test_jobs.py @@ -353,10 +353,6 @@ def test_should_show_scheduled_job( "Sending Two week reminder today at 00:00 US/Eastern" ) - # assert normalize_spaces(page.select_one("main p.notification-status").text) == ( - # "Messages will remain in pending state until carrier status is received, typically 5 minutes." - # ) - assert page.select("main p a")[0]["href"] == url_for( "main.view_template_version", service_id=SERVICE_ONE_ID, @@ -487,6 +483,7 @@ def test_should_show_updates_for_scheduled_job_as_json( def test_time_left(job_created_at, expected_message): assert get_time_left(job_created_at) == expected_message + def test_should_show_message_note( client_request, mock_get_service_template, @@ -502,5 +499,5 @@ def test_should_show_message_note( ) assert normalize_spaces(page.select_one("main p.notification-status").text) == ( - "Messages will remain in pending state until carrier status is received, typically 5 minutes." + "Messages will remain in pending state until carrier status is received, typically 5 minutes." )