darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 15:57:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

log as exception if the api returns 5xx

Browse Source 
if it returns 400 only log warning, as they're much less urgent. it's
probably someone clicking an old invite or something.
This commit is contained in:
Leo Hemsted
2018-03-08 16:10:17 +00:00
parent 1cd8000236
commit 29ae0118f3
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/__init__.py
View File

@@ -488,7 +488,7 @@ def register_errorhandlers(application): # noqa (C901 too complex)
@application.errorhandler(HTTPError) @application.errorhandler(HTTPError)
def render_http_error(error): def render_http_error(error):
application.logger.error("API {} failed with status {} message {}".format( application.logger.warning("API {} failed with status {} message {}".format(
error.response.url if error.response else 'unknown', error.response.url if error.response else 'unknown',
error.status_code, error.status_code,
error.message error.message
@@ -501,7 +501,13 @@ def register_errorhandlers(application): # noqa (C901 too complex)
msg = list(itertools.chain(*[error.message[x] for x in error.message.keys()])) msg = list(itertools.chain(*[error.message[x] for x in error.message.keys()]))
resp = make_response(render_template("error/400.html", message=msg)) resp = make_response(render_template("error/400.html", message=msg))
return useful_headers_after_request(resp) return useful_headers_after_request(resp)
elif error_code not in [401, 404, 403, 410, 500]: elif error_code not in [401, 404, 403, 410]:
# probably a 500 or 503
application.logger.exception("API {} failed with status {} message {}".format(
error.response.url if error.response else 'unknown',
error.status_code,
error.message
))
error_code = 500 error_code = 500
return _error_response(error_code) return _error_response(error_code)