Merge pull request #2510 from alphagov/fix-user-with-no-permissions

Fix the permission check for users without permissions.

tests/app/main/views/test_dashboard.py

@@ -875,6 +875,7 @@ def _test_dashboard_menu(mocker, app_, usr, service, permissions):
     with app_.test_request_context():
         with app_.test_client() as client:
             usr._permissions[str(service['id'])] = permissions
+            usr.services = [service['id']]
             mocker.patch('app.user_api_client.check_verify_code', return_value=(True, ''))
             mocker.patch('app.service_api_client.get_services', return_value={'data': [service]})
             mocker.patch('app.user_api_client.get_user', return_value=usr)

tests/app/main/views/test_templates.py

@@ -1498,7 +1498,7 @@ def test_route_permissions_for_choose_template(
     api_user_active,
     mock_get_template_folders,
     service_one,
-    mock_get_service_templates,
+    mock_get_service_templates
 ):
     mocker.patch('app.job_api_client.get_job')
     validate_route_permission(
@@ -1510,7 +1510,7 @@ def test_route_permissions_for_choose_template(
             'main.choose_template',
             service_id=service_one['id'],
         ),
-        ['view_activity'],
+        [],
         api_user_active,
         service_one)