darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-18 05:29:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

Cache email branding in Redis

Browse Source 
If we’re going to be referring to email branding as part of the service
creation journey then we should make sure it doesn’t slow things down
too much by adding an extra API call. Caching things in Redis is a way
of avoiding unneeded API calls.
This commit is contained in:
Chris Hill-Scott
2018-09-03 10:18:50 +01:00
parent 28f1bcd7f3
commit 28b80856df
2 changed files with 50 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
tests/app/notify_client/test_email_branding_client.py
View File

@@ -1,20 +1,54 @@
from unittest.mock import call
from app.notify_client.email_branding_client import EmailBrandingClient
def test_get_email_branding(mocker, fake_uuid):
mock_get = mocker.patch('app.notify_client.email_branding_client.EmailBrandingClient.get')
mock_get = mocker.patch(
'app.notify_client.email_branding_client.EmailBrandingClient.get',
return_value={'foo': 'bar'}
)
mock_redis_get = mocker.patch(
'app.notify_client.RedisClient.get',
return_value=None,
)
mock_redis_set = mocker.patch(
'app.notify_client.RedisClient.set',
)
EmailBrandingClient().get_email_branding(fake_uuid)
mock_get.assert_called_once_with(
url='/email-branding/{}'.format(fake_uuid)
)
mock_redis_get.assert_called_once_with('email_branding-{}'.format(fake_uuid))
mock_redis_set.assert_called_once_with(
'email_branding-{}'.format(fake_uuid),
'{"foo": "bar"}',
ex=604800,
)
def test_get_all_email_branding(mocker):
mock_get = mocker.patch('app.notify_client.email_branding_client.EmailBrandingClient.get')
mock_get = mocker.patch(
'app.notify_client.email_branding_client.EmailBrandingClient.get',
return_value={'email_branding': [1, 2, 3]}
)
mock_redis_get = mocker.patch(
'app.notify_client.RedisClient.get',
return_value=None,
)
mock_redis_set = mocker.patch(
'app.notify_client.RedisClient.set',
)
EmailBrandingClient().get_all_email_branding()
mock_get.assert_called_once_with(
url='/email-branding'
)
mock_redis_get.assert_called_once_with('email_branding')
mock_redis_set.assert_called_once_with(
'email_branding',
'[1, 2, 3]',
ex=604800,
)
def test_get_letter_email_branding(mocker):
@@ -30,6 +64,7 @@ def test_create_email_branding(mocker):
'domain': 'sample.com', 'brand_type': 'org'}
mock_post = mocker.patch('app.notify_client.email_branding_client.EmailBrandingClient.post')
mock_redis_delete = mocker.patch('app.notify_client.RedisClient.delete')
EmailBrandingClient().create_email_branding(
logo=org_data['logo'], name=org_data['name'], text=org_data['text'], colour=org_data['colour'],
domain=org_data['domain'], brand_type='org'
@@ -40,12 +75,15 @@ def test_create_email_branding(mocker):
data=org_data
)
mock_redis_delete.assert_called_once_with('email_branding')
def test_update_email_branding(mocker, fake_uuid):
org_data = {'logo': 'test.png', 'name': 'test name', 'text': 'test name', 'colour': 'red',
'domain': 'sample.com', 'brand_type': 'org'}
mock_post = mocker.patch('app.notify_client.email_branding_client.EmailBrandingClient.post')
mock_redis_delete = mocker.patch('app.notify_client.RedisClient.delete')
EmailBrandingClient().update_email_branding(
branding_id=fake_uuid, logo=org_data['logo'], name=org_data['name'], text=org_data['text'],
colour=org_data['colour'], domain=org_data['domain'], brand_type='org')
@@ -54,3 +92,7 @@ def test_update_email_branding(mocker, fake_uuid):
url='/email-branding/{}'.format(fake_uuid),
data=org_data
)
assert mock_redis_delete.call_args_list == [
call('email_branding'),
call('email_branding-{}'.format(fake_uuid)),
]