darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-11 10:28:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Replace use of Array.from

Browse Source 
Array.from isn't supported by any version of IE.

We still need to convert a nodelist to an array so
we can either:
1. include the polyfill for Array.from from core-js
2. use [].slice

We don't use Array.from anywhere else so this uses
the second one.
This commit is contained in:
Tom Byers
2020-10-02 14:30:10 +01:00
parent 0e32df4514
commit 2693e5e2b6
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/assets/javascripts/apiKey.js
+2 -1
View File
@@ -29,9 +29,10 @@
this.getRangeFromElement = function (keyElement) { this.getRangeFromElement = function (keyElement) {
const range = document.createRange(); const range = document.createRange();
const childNodes = Array.prototype.slice.call(keyElement.childNodes);
let prefixIndex = -1; let prefixIndex = -1;
Array.from(keyElement.childNodes).forEach((el, idx) => { childNodes.forEach((el, idx) => {
if ((el.nodeType === 1) && el.classList.contains('govuk-visually-hidden')) { if ((el.nodeType === 1) && el.classList.contains('govuk-visually-hidden')) {
prefixIndex = idx; prefixIndex = idx;
} }