darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-18 05:29:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2216 from alphagov/fix-back-link-template-skip

Browse Source 
Fix ‘Back’ link from first step of one off
This commit is contained in:
Chris Hill-Scott
2018-08-10 17:02:23 +01:00
committed by GitHub
parent ec69aa6c39 5a52eafb84
commit 2573aacae8
4 changed files with 53 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
tests/app/main/views/test_send.py
View File

@@ -1482,47 +1482,55 @@ def test_send_test_email_message_without_placeholders_redirects_to_check_page(
assert page.select('h1')[0].text.strip() == 'Preview of ‘Two week reminder’'
@pytest.mark.parametrize('user, expected_back_link_endpoint, extra_args', (
(active_user_with_permissions, 'main.view_template', {'template_id': unchanging_fake_uuid}),
(active_caseworking_user, 'main.choose_template', {}),
@pytest.mark.parametrize('permissions, expected_back_link_endpoint, extra_args', (
(
{'send_messages', 'manage_templates'},
'main.view_template',
{'template_id': unchanging_fake_uuid}
),
(
{'send_messages'},
'main.choose_template',
{},
),
(
{'send_messages', 'view_activity'},
'main.choose_template',
{},
),
))
def test_send_test_sms_message_with_placeholders_shows_first_field(
logged_in_client,
mocker,
service_one,
client_request,
active_user_with_permissions,
mock_login,
mock_get_service,
mock_get_service_template_with_placeholders,
mock_has_no_jobs,
fake_uuid,
user,
permissions,
expected_back_link_endpoint,
extra_args,
):
mocker.patch('app.user_api_client.get_user', return_value=user(fake_uuid))
active_user_with_permissions._permissions[SERVICE_ONE_ID] = permissions
client_request.login(active_user_with_permissions)
with logged_in_client.session_transaction() as session:
with client_request.session_transaction() as session:
assert 'placeholders' not in session
response = logged_in_client.get(
url_for(
'main.send_test',
service_id=service_one['id'],
template_id=unchanging_fake_uuid,
),
follow_redirects=True,
page = client_request.get(
'main.send_test',
service_id=SERVICE_ONE_ID,
template_id=unchanging_fake_uuid,
_follow_redirects=True,
)
assert response.status_code == 200
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
assert page.select('label')[0].text.strip() == 'name'
assert page.select('input')[0]['name'] == 'placeholder_value'
assert page.select('.page-footer-back-link')[0]['href'] == url_for(
expected_back_link_endpoint,
service_id=service_one['id'],
service_id=SERVICE_ONE_ID,
**extra_args
)
with logged_in_client.session_transaction() as session:
with client_request.session_transaction() as session:
assert session['recipient'] == '07700 900762'