Refactor use ServiceOnOffForm

We no longer need a custom form object here – ServiceOnOffForm does the
same job of turning strings to booleans and back again.
This commit is contained in:
Chris Hill-Scott
2020-05-29 09:55:34 +01:00
parent cd398ab55c
commit 24f0b172f4
3 changed files with 8 additions and 18 deletions

View File

@@ -1719,16 +1719,6 @@ class ServiceDeliveryStatusCallbackForm(CallbackForm):
)
class InternationalSMSForm(StripWhitespaceForm):
enabled = RadioField(
'Send text messages to international phone numbers',
choices=[
('on', 'On'),
('off', 'Off'),
],
)
class SMSPrefixForm(StripWhitespaceForm):
enabled = RadioField(
'',

View File

@@ -35,7 +35,6 @@ from app.main.forms import (
ConfirmPasswordForm,
EstimateUsageForm,
FreeSMSAllowance,
InternationalSMSForm,
LinkOrganisationsForm,
PreviewBranding,
RenameServiceForm,
@@ -648,13 +647,14 @@ def service_set_sms_prefix(service_id):
@main.route("/services/<uuid:service_id>/service-settings/set-international-sms", methods=['GET', 'POST'])
@user_has_permissions('manage_service')
def service_set_international_sms(service_id):
form = InternationalSMSForm(
enabled='on' if current_service.has_permission('international_sms') else 'off'
form = ServiceOnOffSettingForm(
'Send text messages to international phone numbers',
enabled=current_service.has_permission('international_sms'),
)
if form.validate_on_submit():
current_service.force_permission(
'international_sms',
on=(form.enabled.data == 'on'),
on=form.enabled.data,
)
return redirect(
url_for(".service_settings", service_id=service_id)