darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make reply to address dependent on sending intent

Browse Source 
We have a number of go live requests where people have said they’re
sending email, but haven’t set up a reply-to address. At the moment we
don’t prompt them to, because we look at whether they have email
templates as indicative of whether they’re going to send email.

Now that we explicitly ask for the volumes of email they’re sending we
should use this to determine whether or not we prompt them to set up an
email reply to address because it’s a stronger signal of intent than
what templates they’ve set up.
This commit is contained in:
Chris Hill-Scott
2019-03-01 14:11:33 +00:00
parent 9bdcd81c65
commit 24ee280632
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/app/main/views/test_service_settings.py
View File

@@ -1160,7 +1160,7 @@ def test_should_redirect_after_request_to_go_live(
True,
True,
True,
1, 1, 1,
1, 0, 0,
'Yes',
True,
[
@@ -1194,7 +1194,7 @@ def test_should_redirect_after_request_to_go_live(
True,
True,
False,
1, 1, 1,
0, 1, 0,
'Yes',
True,
[
@@ -1210,7 +1210,7 @@ def test_should_redirect_after_request_to_go_live(
True,
True,
True,
1, 1, 1,
0, 1, 0,
'No',
True,
[
@@ -1246,7 +1246,7 @@ def test_should_redirect_after_request_to_go_live(
True,
True,
False,
1, 1, 1,
0, 1, 0,
'No',
True,
[
@@ -1256,7 +1256,7 @@ def test_should_redirect_after_request_to_go_live(
'notify_request_to_go_live_incomplete_template_content',
],
),
( # Everything is wrong
( # Not done anything yet
False,
False,
True,
@@ -1273,7 +1273,6 @@ def test_should_redirect_after_request_to_go_live(
'notify_request_to_go_live_incomplete_volumes',
'notify_request_to_go_live_incomplete_checklist',
'notify_request_to_go_live_incomplete_mou',
'notify_request_to_go_live_incomplete_email_reply_to',
'notify_request_to_go_live_incomplete_team_member',
'notify_request_to_go_live_incomplete_template_content',
'notify_request_to_go_live_incomplete_sms_sender',