Replace message count macros with formatters

We prefer formatters now. Removing uses of the aliasing macro lets
remove it entirely.
This commit is contained in:
Chris Hill-Scott
2021-01-06 13:41:16 +00:00
parent 0327ece7ad
commit 24b579418f
34 changed files with 36 additions and 77 deletions

View File

@@ -1,3 +1 @@
{% macro message_count_label(count, template_type, suffix='sent') -%}
{{ count|message_count_noun(template_type) }} {{ suffix }}
{%- endmacro %}

View File

@@ -1,12 +1,11 @@
{% from 'components/big-number.html' import big_number %} {% from 'components/big-number.html' import big_number %}
{% from 'components/message-count-label.html' import message_count_label %}
<div class="govuk-grid-row bottom-gutter-2-3"> <div class="govuk-grid-row bottom-gutter-2-3">
<div class="govuk-grid-column-one-half"> <div class="govuk-grid-column-one-half">
<div class="keyline-block"> <div class="keyline-block">
{{ big_number( {{ big_number(
job.notification_count, job.notification_count,
message_count_label(job.notification_count, 'letter', suffix='')|capitalize, job.notification_count|message_count_label('letter', suffix='')|capitalize,
smaller=True smaller=True
)}} )}}
</div> </div>

View File

@@ -1,7 +1,6 @@
{% extends "withnav_template.html" %} {% extends "withnav_template.html" %}
{% from "components/table.html" import list_table, field, hidden_field_heading %} {% from "components/table.html" import list_table, field, hidden_field_heading %}
{% from "components/banner.html" import banner_wrapper %} {% from "components/banner.html" import banner_wrapper %}
{% from "components/message-count-label.html" import message_count_label %}
{% block service_page_title %} {% block service_page_title %}
API integration API integration
@@ -76,7 +75,7 @@
{% endif %} {% endif %}
{% endfor %} {% endfor %}
{% if notification.status not in ('pending-virus-check', 'virus-scan-failed') %} {% if notification.status not in ('pending-virus-check', 'virus-scan-failed') %}
<a class="govuk-link govuk-link--no-visited-state" href="{{ url_for('.view_notification', service_id=current_service.id, notification_id=notification.id) }}">View {{ message_count_label(1, notification.template.template_type, suffix='') }}</a> <a class="govuk-link govuk-link--no-visited-state" href="{{ url_for('.view_notification', service_id=current_service.id, notification_id=notification.id) }}">View {{ 1|message_count_label(notification.template.template_type, suffix='') }}</a>
{% endif %} {% endif %}
</dl> </dl>
</div> </div>

View File

@@ -4,7 +4,6 @@
{% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading %} {% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading %}
{% from "components/file-upload.html" import file_upload %} {% from "components/file-upload.html" import file_upload %}
{% from "components/back-link/macro.njk" import govukBackLink %} {% from "components/back-link/macro.njk" import govukBackLink %}
{% from "components/message-count-label.html" import message_count_label %}
{% block service_page_title %} {% block service_page_title %}
Error Error

View File

@@ -3,7 +3,6 @@
{% from "components/radios.html" import radio_select %} {% from "components/radios.html" import radio_select %}
{% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading %} {% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading %}
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/button/macro.njk" import govukButton %} {% from "components/button/macro.njk" import govukButton %}
{% from "components/skip-link/macro.njk" import govukSkipLink %} {% from "components/skip-link/macro.njk" import govukSkipLink %}
@@ -44,7 +43,7 @@
{% endif %} {% endif %}
{% if (template.template_type != 'letter' or not request.args.from_test) and not letter_too_long %} {% if (template.template_type != 'letter' or not request.args.from_test) and not letter_too_long %}
{% set button_text %} {% set button_text %}
Send {{ count_of_recipients|format_thousands }} {{ message_count_label(count_of_recipients, template.template_type, suffix='') }} Send {{ count_of_recipients|message_count(template.template_type) }}
{% endset %} {% endset %}
{{ govukButton({ "text": button_text }) }} {{ govukButton({ "text": button_text }) }}
{% else %} {% else %}

View File

@@ -4,7 +4,6 @@
{% from "components/table.html" import mapping_table, row, field, text_field, index_field, hidden_field_heading %} {% from "components/table.html" import mapping_table, row, field, text_field, index_field, hidden_field_heading %}
{% from "components/file-upload.html" import file_upload %} {% from "components/file-upload.html" import file_upload %}
{% from "components/back-link/macro.njk" import govukBackLink %} {% from "components/back-link/macro.njk" import govukBackLink %}
{% from "components/message-count-label.html" import message_count_label %}
{% block service_page_title %} {% block service_page_title %}
Error Error

View File

@@ -1,5 +1,3 @@
{% from "components/message-count-label.html" import message_count_label %}
<div class="ajax-block"> <div class="ajax-block">
{% if current_service.inbound_sms_summary != None %} {% if current_service.inbound_sms_summary != None %}
<a id="total-received" class="govuk-link govuk-link--no-visited-state banner-dashboard" class="banner-dashboard" href="{{ url_for('.inbox', service_id=current_service.id) }}"> <a id="total-received" class="govuk-link govuk-link--no-visited-state banner-dashboard" class="banner-dashboard" href="{{ url_for('.inbox', service_id=current_service.id) }}">
@@ -7,7 +5,7 @@
{{ current_service.inbound_sms_summary.count|format_thousands }} {{ current_service.inbound_sms_summary.count|format_thousands }}
</span> </span>
<span class="banner-dashboard-count-label"> <span class="banner-dashboard-count-label">
{{ message_count_label(current_service.inbound_sms_summary.count, 'sms', suffix='received') }} {{ current_service.inbound_sms_summary.count|message_count_label('sms', suffix='received') }}
</span> </span>
{% if current_service.inbound_sms_summary.most_recent %} {% if current_service.inbound_sms_summary.most_recent %}
<span class="banner-dashboard-meta"> <span class="banner-dashboard-meta">
@@ -22,7 +20,7 @@
{{ current_service.count_of_returned_letters_in_last_7_days|format_thousands }} {{ current_service.count_of_returned_letters_in_last_7_days|format_thousands }}
</span> </span>
<span class="banner-dashboard-count-label"> <span class="banner-dashboard-count-label">
returned {{ message_count_label(current_service.count_of_returned_letters_in_last_7_days, 'letter', suffix='') }} returned {{ current_service.count_of_returned_letters_in_last_7_days|message_count_label('letter', suffix='') }}
</span> </span>
<span class="banner-dashboard-meta"> <span class="banner-dashboard-meta">
latest report {{ current_service.date_of_most_recent_returned_letter_report|format_delta_days }} latest report {{ current_service.date_of_most_recent_returned_letter_report|format_delta_days }}

View File

@@ -1,6 +1,5 @@
{% from "components/table.html" import list_table, field, hidden_field_heading, right_aligned_field_heading, row_heading %} {% from "components/table.html" import list_table, field, hidden_field_heading, right_aligned_field_heading, row_heading %}
{% from "components/previous-next-navigation.html" import previous_next_navigation %} {% from "components/previous-next-navigation.html" import previous_next_navigation %}
{% from "components/message-count-label.html" import message_count_label %}
<div class="ajax-block-container"> <div class="ajax-block-container">
{% if messages %} {% if messages %}

View File

@@ -1,6 +1,5 @@
{% from "components/table.html" import list_table, field, right_aligned_field_heading, row_heading %} {% from "components/table.html" import list_table, field, right_aligned_field_heading, row_heading %}
{% from "components/big-number.html" import big_number -%} {% from "components/big-number.html" import big_number -%}
{% from "components/message-count-label.html" import message_count_label %}
<div class='dashboard-table ajax-block-container'> <div class='dashboard-table ajax-block-container'>
{% call(item, row_number) list_table( {% call(item, row_number) list_table(
@@ -66,8 +65,7 @@
{{ big_number( {{ big_number(
item.notification_count, item.notification_count,
smallest=True, smallest=True,
label=message_count_label( label=item.notification_count|message_count_label(
item.notification_count,
item.template_type, item.template_type,
suffix='waiting to send' suffix='waiting to send'
) )
@@ -76,8 +74,7 @@
{{ big_number( {{ big_number(
item.notification_count, item.notification_count,
smallest=True, smallest=True,
label=message_count_label( label=item.notification_count|message_count_label(
item.notification_count,
item.template_type, item.template_type,
suffix='' suffix=''
) )

View File

@@ -1,12 +1,11 @@
{% from "components/big-number.html" import big_number_with_status %} {% from "components/big-number.html" import big_number_with_status %}
{% from "components/message-count-label.html" import message_count_label %}
<div class="ajax-block-container"> <div class="ajax-block-container">
<div class="govuk-grid-row"> <div class="govuk-grid-row">
<div id="total-email" class="govuk-grid-column-one-third"> <div id="total-email" class="govuk-grid-column-one-third">
{{ big_number_with_status( {{ big_number_with_status(
statistics['email']['requested'], statistics['email']['requested'],
message_count_label(statistics['email']['requested'], 'email', suffix='sent'), statistics['email']['requested']|message_count_label('email', suffix='sent'),
statistics['email']['failed'], statistics['email']['failed'],
statistics['email']['failed_percentage'], statistics['email']['failed_percentage'],
statistics['email']['show_warning'], statistics['email']['show_warning'],
@@ -18,7 +17,7 @@
<div id="total-sms" class="govuk-grid-column-one-third"> <div id="total-sms" class="govuk-grid-column-one-third">
{{ big_number_with_status( {{ big_number_with_status(
statistics['sms']['requested'], statistics['sms']['requested'],
message_count_label(statistics['sms']['requested'], 'sms', suffix='sent'), statistics['sms']['requested']|message_count_label('sms', suffix='sent'),
statistics['sms']['failed'], statistics['sms']['failed'],
statistics['sms']['failed_percentage'], statistics['sms']['failed_percentage'],
statistics['sms']['show_warning'], statistics['sms']['show_warning'],
@@ -30,7 +29,7 @@
<div id="total-letters" class="govuk-grid-column-one-third"> <div id="total-letters" class="govuk-grid-column-one-third">
{{ big_number_with_status( {{ big_number_with_status(
statistics['letter']['requested'], statistics['letter']['requested'],
message_count_label(statistics['letter']['requested'], 'letter', suffix='sent'), statistics['letter']['requested']|message_count_label('letter', suffix='sent'),
statistics['letter']['failed'], statistics['letter']['failed'],
statistics['letter']['failed_percentage'], statistics['letter']['failed_percentage'],
statistics['letter']['show_warning'], statistics['letter']['show_warning'],

View File

@@ -1,5 +1,4 @@
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/pill.html" import pill %} {% from "components/pill.html" import pill %}
{% from "components/table.html" import list_table, field, right_aligned_field_heading, row_heading, spark_bar_field %} {% from "components/table.html" import list_table, field, right_aligned_field_heading, row_heading, spark_bar_field %}
@@ -44,7 +43,7 @@
{% call row_heading() %} {% call row_heading() %}
<a class="govuk-link govuk-link--no-visited-state template-statistics-table-template-name" href="{{ url_for('.view_template', service_id=current_service.id, template_id=item.id) }}">{{ item.name }}</a> <a class="govuk-link govuk-link--no-visited-state template-statistics-table-template-name" href="{{ url_for('.view_template', service_id=current_service.id, template_id=item.id) }}">{{ item.name }}</a>
<span class="template-statistics-table-hint"> <span class="template-statistics-table-hint">
{{ message_count_label(1, item.type, suffix='template')|capitalize }} {{ 1|message_count_label(item.type, suffix='template')|capitalize }}
</span> </span>
{% endcall %} {% endcall %}
{{ spark_bar_field(item.requested_count, most_used_template_count) }} {{ spark_bar_field(item.requested_count, most_used_template_count) }}

View File

@@ -1,7 +1,6 @@
{% extends "withnav_template.html" %} {% extends "withnav_template.html" %}
{% from "components/show-more.html" import show_more %} {% from "components/show-more.html" import show_more %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/table.html" import list_table, field, right_aligned_field_heading, hidden_field_heading %} {% from "components/table.html" import list_table, field, right_aligned_field_heading, hidden_field_heading %}
{% from "components/ajax-block.html" import ajax_block %} {% from "components/ajax-block.html" import ajax_block %}

View File

@@ -2,7 +2,6 @@
{% from "components/big-number.html" import big_number_with_status, big_number %} {% from "components/big-number.html" import big_number_with_status, big_number %}
{% from "components/pill.html" import pill %} {% from "components/pill.html" import pill %}
{% from "components/table.html" import list_table, field, hidden_field_heading, right_aligned_field_heading, row_heading %} {% from "components/table.html" import list_table, field, hidden_field_heading, right_aligned_field_heading, row_heading %}
{% from "components/message-count-label.html" import message_count_label %}
{% extends "withnav_template.html" %} {% extends "withnav_template.html" %}
@@ -49,7 +48,7 @@
{% call field(align='left') %} {% call field(align='left') %}
{{ big_number( {{ big_number(
counts.requested, counts.requested,
message_count_label(counts.requested, template_type, suffix=''), counts.requested|message_count_label(template_type, suffix=''),
smallest=True, smallest=True,
) }} ) }}
{% if counts.requested %} {% if counts.requested %}

View File

@@ -1,5 +1,4 @@
{% from "components/big-number.html" import big_number %} {% from "components/big-number.html" import big_number %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/big-number.html" import big_number %} {% from "components/big-number.html" import big_number %}
{% from "components/table.html" import list_table, field, right_aligned_field_heading, row_heading, spark_bar_field %} {% from "components/table.html" import list_table, field, right_aligned_field_heading, row_heading, spark_bar_field %}
{% from "components/show-more.html" import show_more %} {% from "components/show-more.html" import show_more %}
@@ -30,7 +29,7 @@
{% else %} {% else %}
<a class="govuk-link govuk-link--no-visited-state template-statistics-table-template-name" href="{{ url_for('.view_template', service_id=current_service.id, template_id=item.template_id) }}">{{ item.template_name }}</a> <a class="govuk-link govuk-link--no-visited-state template-statistics-table-template-name" href="{{ url_for('.view_template', service_id=current_service.id, template_id=item.template_id) }}">{{ item.template_name }}</a>
<span class="template-statistics-table-hint"> <span class="template-statistics-table-hint">
{{ message_count_label(1, item.template_type, suffix='template')|capitalize }} {{ 1|message_count_label(item.template_type, suffix='template')|capitalize }}
</span> </span>
{% endif %} {% endif %}
{% endcall %} {% endcall %}

View File

@@ -1,6 +1,5 @@
{% extends "withnav_template.html" %} {% extends "withnav_template.html" %}
{% from "components/ajax-block.html" import ajax_block %} {% from "components/ajax-block.html" import ajax_block %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}
{% from "components/page-footer.html" import page_footer %} {% from "components/page-footer.html" import page_footer %}
{% from "components/form.html" import form_wrapper %} {% from "components/form.html" import form_wrapper %}
@@ -12,7 +11,7 @@
else '' else ''
) %} ) %}
{% set page_title = ( {% set page_title = (
(title_status + message_count_label(99, message_type, suffix='')) | capitalize (title_status + 99|message_count_label(message_type, suffix='')) | capitalize
if current_user.has_permissions('view_activity') if current_user.has_permissions('view_activity')
else 'Sent messages' else 'Sent messages'
) %} ) %}

View File

@@ -1,6 +1,5 @@
{% extends "withnav_template.html" %} {% extends "withnav_template.html" %}
{% from "components/banner.html" import banner_wrapper %} {% from "components/banner.html" import banner_wrapper %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}
{% from "components/back-link/macro.njk" import govukBackLink %} {% from "components/back-link/macro.njk" import govukBackLink %}
{% from "components/button/macro.njk" import govukButton %} {% from "components/button/macro.njk" import govukButton %}
@@ -77,7 +76,7 @@
)}}" class='page-footer'> )}}" class='page-footer'>
<input type="hidden" name="csrf_token" value="{{ csrf_token() }}" /> <input type="hidden" name="csrf_token" value="{{ csrf_token() }}" />
{% if not error %} {% if not error %}
{% set button_text %}Send 1 {{ message_count_label(1, template.template_type, suffix='') }}{% endset %} {% set button_text %}Send 1 {{ 1|message_count_label(template.template_type, suffix='') }}{% endset %}
{{ govukButton({ "text": button_text }) }} {{ govukButton({ "text": button_text }) }}
{% endif %} {% endif %}
{% if template.template_type == 'letter' %} {% if template.template_type == 'letter' %}

View File

@@ -1,18 +1,17 @@
{% extends "withnav_template.html" %} {% extends "withnav_template.html" %}
{% from "components/banner.html" import banner %} {% from "components/banner.html" import banner %}
{% from "components/ajax-block.html" import ajax_block %} {% from "components/ajax-block.html" import ajax_block %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}
{% from "components/page-footer.html" import page_footer %} {% from "components/page-footer.html" import page_footer %}
{% block service_page_title %} {% block service_page_title %}
{{ message_count_label(1, template.template_type, suffix='') | capitalize }} {{ 1|message_count_label(template.template_type, suffix='') | capitalize }}
{% endblock %} {% endblock %}
{% block maincolumn_content %} {% block maincolumn_content %}
{{ page_header( {{ page_header(
message_count_label(1, template.template_type, suffix='') | capitalize, 1|message_count_label(template.template_type, suffix='') | capitalize,
back_link=back_link back_link=back_link
) }} ) }}
<p class="govuk-body"> <p class="govuk-body">

View File

@@ -1,7 +1,6 @@
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}
{% from "components/big-number.html" import big_number %} {% from "components/big-number.html" import big_number %}
{% from "components/live-search.html" import live_search %} {% from "components/live-search.html" import live_search %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/pill.html" import pill %} {% from "components/pill.html" import pill %}
{% extends "org_template.html" %} {% extends "org_template.html" %}
@@ -74,7 +73,7 @@
<div class="govuk-grid-column-one-third"> <div class="govuk-grid-column-one-third">
{{ big_number( {{ big_number(
service.emails_sent, service.emails_sent,
label=message_count_label(service.emails_sent, 'email'), label=service.emails_sent|message_count_label('email'),
smallest=True smallest=True
) }} ) }}
</div> </div>
@@ -89,7 +88,7 @@
{% else %} {% else %}
{{ big_number( {{ big_number(
service.sms_billable_units, service.sms_billable_units,
'free {}'.format(message_count_label(service.sms_billable_units, 'sms')), 'free {}'.format(service.sms_billable_units|message_count_label('sms')),
smallest=True smallest=True
) }} ) }}
{% endif %} {% endif %}

View File

@@ -1,10 +1,10 @@
{% from "components/big-number.html" import big_number_with_status %} {% from "components/big-number.html" import big_number_with_status %}
{% from "components/message-count-label.html" import message_count_label %}
<div class="govuk-grid-row bottom-gutter"> <div class="govuk-grid-row bottom-gutter">
<div class="govuk-grid-column-one-third"> <div class="govuk-grid-column-one-third">
{{ big_number_with_status( {{ big_number_with_status(
global_stats.email.delivered + global_stats.email.failed, global_stats.email.delivered + global_stats.email.failed,
message_count_label(global_stats.email.delivered, 'email'), global_stats.email.delivered|message_count_label('email'),
global_stats.email.failed, global_stats.email.failed,
global_stats.email.failure_rate, global_stats.email.failure_rate,
global_stats.email.failure_rate|float > 3, global_stats.email.failure_rate|float > 3,
@@ -14,7 +14,7 @@
<div class="govuk-grid-column-one-third"> <div class="govuk-grid-column-one-third">
{{ big_number_with_status( {{ big_number_with_status(
global_stats.sms.delivered + global_stats.sms.failed, global_stats.sms.delivered + global_stats.sms.failed,
message_count_label(global_stats.sms.delivered, 'sms'), global_stats.sms.delivered|message_count_label('sms'),
global_stats.sms.failed, global_stats.sms.failed,
global_stats.sms.failure_rate, global_stats.sms.failure_rate,
global_stats.sms.failure_rate|float > 3, global_stats.sms.failure_rate|float > 3,
@@ -24,7 +24,7 @@
<div class="govuk-grid-column-one-third"> <div class="govuk-grid-column-one-third">
{{ big_number_with_status( {{ big_number_with_status(
global_stats.letter.requested, global_stats.letter.requested,
message_count_label(global_stats.letter.requested, 'letter'), global_stats.letter.requested|message_count_label('letter'),
global_stats.letter.failed, global_stats.letter.failed,
global_stats.letter.failure_rate, global_stats.letter.failure_rate,
global_stats.letter.failure_rate|float > 3, global_stats.letter.failure_rate|float > 3,

View File

@@ -1,6 +1,5 @@
{% extends "views/platform-admin/_base_template.html" %} {% extends "views/platform-admin/_base_template.html" %}
{% from "components/big-number.html" import big_number_simple %} {% from "components/big-number.html" import big_number_simple %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/status-box.html" import status_box %} {% from "components/status-box.html" import status_box %}
{% from "components/form.html" import form_wrapper %} {% from "components/form.html" import form_wrapper %}
{% from "components/details/macro.njk" import govukDetails %} {% from "components/details/macro.njk" import govukDetails %}
@@ -36,7 +35,7 @@
<div class="govuk-grid-column-one-third"> <div class="govuk-grid-column-one-third">
{{ big_number_simple( {{ big_number_simple(
noti_type.black_box.number, noti_type.black_box.number,
message_count_label(noti_type.black_box.number, noti_type.black_box.notification_type) noti_type.black_box.number|message_count_label(noti_type.black_box.notification_type)
) }} ) }}
{% for item in noti_type.other_data %} {% for item in noti_type.other_data %}

View File

@@ -1,7 +1,6 @@
{% extends "views/platform-admin/_base_template.html" %} {% extends "views/platform-admin/_base_template.html" %}
{% from "components/page-footer.html" import page_footer %} {% from "components/page-footer.html" import page_footer %}
{% from "components/big-number.html" import big_number, big_number_with_status %} {% from "components/big-number.html" import big_number, big_number_with_status %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/table.html" import mapping_table, field, stats_fields, row_group, row, right_aligned_field_heading, hidden_field_heading, text_field %} {% from "components/table.html" import mapping_table, field, stats_fields, row_group, row, right_aligned_field_heading, hidden_field_heading, text_field %}
{% from "components/form.html" import form_wrapper %} {% from "components/form.html" import form_wrapper %}
{% from "components/button/macro.njk" import govukButton %} {% from "components/button/macro.njk" import govukButton %}
@@ -39,7 +38,7 @@
{{ big_number( {{ big_number(
service['stats'][channel]['requested'], service['stats'][channel]['requested'],
smallest=True, smallest=True,
label=message_count_label(service['stats'][channel]['requested'], channel) label=service['stats'][channel]['requested']|message_count_label(channel)
) }} ) }}
{% endcall %} {% endcall %}
{% endfor %} {% endfor %}

View File

@@ -1,5 +1,4 @@
{% from "components/table.html" import list_table, row_heading %} {% from "components/table.html" import list_table, row_heading %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}
{% extends "withnav_template.html" %} {% extends "withnav_template.html" %}
@@ -35,7 +34,7 @@
<a class="govuk-link govuk-link--no-visited-state file-list-filename" <a class="govuk-link govuk-link--no-visited-state file-list-filename"
href="{{url_for('.returned_letters', service_id=current_service.id, reported_at=item.reported_at)}}">{{ item.reported_at | format_date_normal }}</a> href="{{url_for('.returned_letters', service_id=current_service.id, reported_at=item.reported_at)}}">{{ item.reported_at | format_date_normal }}</a>
<p class="file-list-hint"> <p class="file-list-hint">
{{ item.returned_letter_count}} {{ message_count_label(item.returned_letter_count, 'letter', suffix='')}} {{ item.returned_letter_count}} {{ item.returned_letter_count|message_count_label('letter', suffix='')}}
</p> </p>
{% endcall %} {% endcall %}
{% endcall %} {% endcall %}

View File

@@ -1,5 +1,4 @@
{% from "components/table.html" import list_table, field %} {% from "components/table.html" import list_table, field %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}
{% extends "withnav_template.html" %} {% extends "withnav_template.html" %}

View File

@@ -1,4 +1,3 @@
{% from 'components/message-count-label.html' import message_count_label %}
{% from "components/banner.html" import banner_wrapper %} {% from "components/banner.html" import banner_wrapper %}
<div class="govuk-grid-column-full"> <div class="govuk-grid-column-full">
@@ -9,7 +8,7 @@
{% elif not current_user.has_permissions('send_messages', 'manage_api_keys', 'manage_templates', 'manage_service') or not user_has_template_permission %} {% elif not current_user.has_permissions('send_messages', 'manage_api_keys', 'manage_templates', 'manage_service') or not user_has_template_permission %}
<p class="top-gutter-1-3 {% if template.template_type != 'sms' %}bottom-gutter{% endif %}"> <p class="top-gutter-1-3 {% if template.template_type != 'sms' %}bottom-gutter{% endif %}">
If you need to send this If you need to send this
{{ message_count_label(1, template.template_type, suffix='') }} {{ 1|message_count_label(template.template_type, suffix='') }}
or edit this template, contact your manager. or edit this template, contact your manager.
</p> </p>
{% else %} {% else %}

View File

@@ -1,5 +1,3 @@
{% from "components/message-count-label.html" import folder_contents_count, message_count_label %}
{% macro format_item_name(name, separators=True) -%} {% macro format_item_name(name, separators=True) -%}
{%- if name is string -%} {%- if name is string -%}
{{- name -}} {{- name -}}
@@ -19,7 +17,7 @@
{% if template_list.folder_is_empty %} {% if template_list.folder_is_empty %}
This folder is empty This folder is empty
{% else %} {% else %}
There are no {{ message_count_label(1, template_type, suffix='') }} templates in this folder There are no {{ 1|message_count_label(template_type, suffix='') }} templates in this folder
{% endif %} {% endif %}
</p> </p>
{% else %} {% else %}

View File

@@ -1,7 +1,6 @@
{% extends "withnav_template.html" %} {% extends "withnav_template.html" %}
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}
{% from "components/page-footer.html" import page_footer %} {% from "components/page-footer.html" import page_footer %}
{% from "components/message-count-label.html" import message_count_label %}
{% block service_page_title %} {% block service_page_title %}
{{ notification_type.capitalize() }} are disabled {{ notification_type.capitalize() }} are disabled
@@ -16,10 +15,10 @@
back_link=back_link, back_link=back_link,
) }} ) }}
<p class="govuk-body"> <p class="govuk-body">
Sending {{ message_count_label(999, notification_type, suffix='') -}} has been disabled for your service. Sending {{ 999|message_count_label(notification_type, suffix='') }} has been disabled for your service.
</p> </p>
<p class="govuk-body"> <p class="govuk-body">
If you need to send {{ message_count_label(999, notification_type, suffix='') }} If you need to send {{ 999|message_count_label(notification_type, suffix='') }}
<a class="govuk-link govuk-link--no-visited-state" href="{{ url_for('.support') }}">get in touch with the GOV.UK Notify team</a>. <a class="govuk-link govuk-link--no-visited-state" href="{{ url_for('.support') }}">get in touch with the GOV.UK Notify team</a>.
</p> </p>

View File

@@ -1,6 +1,5 @@
{% from "components/folder-path.html" import folder_path, page_title_folder_path %} {% from "components/folder-path.html" import folder_path, page_title_folder_path %}
{% from "components/pill.html" import pill %} {% from "components/pill.html" import pill %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/live-search.html" import live_search %} {% from "components/live-search.html" import live_search %}
{% from "components/form.html" import form_wrapper %} {% from "components/form.html" import form_wrapper %}
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}

View File

@@ -4,7 +4,6 @@
{% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading %} {% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading %}
{% from "components/file-upload.html" import file_upload %} {% from "components/file-upload.html" import file_upload %}
{% from "components/back-link/macro.njk" import govukBackLink %} {% from "components/back-link/macro.njk" import govukBackLink %}
{% from "components/message-count-label.html" import message_count_label %}
{% block service_page_title %} {% block service_page_title %}
Error Error

View File

@@ -4,7 +4,6 @@
{% from "components/radios.html" import radio_select %} {% from "components/radios.html" import radio_select %}
{% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading, row, row_heading %} {% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading, row, row_heading %}
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/button/macro.njk" import govukButton %} {% from "components/button/macro.njk" import govukButton %}
{% block service_page_title %} {% block service_page_title %}
@@ -64,8 +63,7 @@
{{ big_number( {{ big_number(
item.notification_count, item.notification_count,
smallest=True, smallest=True,
label=message_count_label( label=item.notification_count|message_count_label(
item.notification_count,
item.template_type, item.template_type,
suffix='waiting to send' suffix='waiting to send'
) )

View File

@@ -3,7 +3,6 @@
{% from "components/radios.html" import radio_select %} {% from "components/radios.html" import radio_select %}
{% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading %} {% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading %}
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/button/macro.njk" import govukButton %} {% from "components/button/macro.njk" import govukButton %}
{% block service_page_title %} {% block service_page_title %}

View File

@@ -4,8 +4,6 @@
{% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading %} {% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading %}
{% from "components/file-upload.html" import file_upload %} {% from "components/file-upload.html" import file_upload %}
{% from "components/back-link/macro.njk" import govukBackLink %} {% from "components/back-link/macro.njk" import govukBackLink %}
{% from "components/message-count-label.html" import message_count_label %}
{% block service_page_title %} {% block service_page_title %}
Error Error

View File

@@ -4,8 +4,6 @@
{% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading %} {% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading %}
{% from "components/file-upload.html" import file_upload %} {% from "components/file-upload.html" import file_upload %}
{% from "components/back-link/macro.njk" import govukBackLink %} {% from "components/back-link/macro.njk" import govukBackLink %}
{% from "components/message-count-label.html" import message_count_label %}
{% block service_page_title %} {% block service_page_title %}
Error Error

View File

@@ -1,5 +1,4 @@
{% extends "withnav_template.html" %} {% extends "withnav_template.html" %}
{% from 'components/message-count-label.html' import message_count_label %}
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}
{% block service_page_title %} {% block service_page_title %}
@@ -16,7 +15,7 @@
{% if notifications %} {% if notifications %}
<p class='govuk-body'> <p class='govuk-body'>
{{ total|format_thousands}} {{ message_count_label(total, 'letter', suffix='') }} {{ total|message_count('letter') }}
</p> </p>
<p class='govuk-body'> <p class='govuk-body'>

View File

@@ -1,5 +1,4 @@
{% from "components/big-number.html" import big_number %} {% from "components/big-number.html" import big_number %}
{% from "components/message-count-label.html" import message_count_label %}
{% from "components/table.html" import list_table, field, hidden_field_heading, row_heading, text_field %} {% from "components/table.html" import list_table, field, hidden_field_heading, row_heading, text_field %}
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}
{% from "components/pill.html" import pill %} {% from "components/pill.html" import pill %}
@@ -102,15 +101,15 @@
) }} ) }}
<ul> <ul>
{% if month.free %} {% if month.free %}
<li class="tabular-numbers">{{ "{:,}".format(month.free) }} free {{ message_count_label(month.free, 'sms', '') }}</li> <li class="tabular-numbers">{{ month.free|format_thousands }} free {{ month.free|message_count_label('sms', suffix='') }}</li>
{% endif %} {% endif %}
{% if month.paid %} {% if month.paid %}
<li class="tabular-numbers">{{ "{:,}".format(month.paid) }} {{ message_count_label(month.paid, 'sms', '') }}at <li class="tabular-numbers">{{ month.paid|message_count('sms') }} at
{{- ' {:.2f}p'.format(sms_rate * 100) }}</li> {{- ' {:.2f}p'.format(sms_rate * 100) }}</li>
{% endif %} {% endif %}
{% for letter in month.letters%} {% for letter in month.letters%}
{% if letter.billing_units %} {% if letter.billing_units %}
<li class="tabular-numbers">{{ "{:,} {}".format(letter.billing_units, letter.postage_description) }} {{ message_count_label(letter.billing_units, 'letter', '') }}at <li class="tabular-numbers">{{ "{:,} {}".format(letter.billing_units, letter.postage_description) }} {{ letter.billing_units|message_count_label('letter', suffix='') }} at
{{ letter.rate | format_number_in_pounds_as_currency }}</li> {{ letter.rate | format_number_in_pounds_as_currency }}</li>
{% endif %} {% endif %}
{% endfor %} {% endfor %}