darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-10 10:03:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Rename endpoint to remove term ‘whitelist’

Browse Source 
See c31264d4c for rationale. To avoid confusion the codebase should use
the same terminology as the UI.
This commit is contained in:
Chris Hill-Scott
2020-06-12 09:03:40 +01:00
parent bf6bd8ad0f
commit 23f9728108
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/main/views/api_keys.py
View File

@@ -54,7 +54,7 @@ def api_documentation(service_id):
@main.route("/services/<uuid:service_id>/api/whitelist", methods=['GET', 'POST']) @main.route("/services/<uuid:service_id>/api/whitelist", methods=['GET', 'POST'])
@user_has_permissions('manage_api_keys') @user_has_permissions('manage_api_keys')
def whitelist(service_id): def guest_list(service_id):
form = GuestList() form = GuestList()
if form.validate_on_submit(): if form.validate_on_submit():
service_api_client.update_whitelist(service_id, { service_api_client.update_whitelist(service_id, {

8
app/navigation.py
View File

@@ -348,7 +348,7 @@ class HeaderNavigation(Navigation):
'view_template_version', 'view_template_version',
'no_cookie.view_template_version_preview', 'no_cookie.view_template_version_preview',
'view_template_versions', 'view_template_versions',
'whitelist', 'guest_list',
'who_can_use_notify', 'who_can_use_notify',
'who_its_for', 'who_its_for',
} }
@@ -480,7 +480,7 @@ class MainNavigation(Navigation):
'delivery_status_callback', 'delivery_status_callback',
'received_text_messages_callback', 'received_text_messages_callback',
'revoke_api_key', 'revoke_api_key',
'whitelist', 'guest_list',
}, },
} }
@@ -975,7 +975,7 @@ class CaseworkNavigation(Navigation):
'view_template_version', 'view_template_version',
'no_cookie.view_template_version_preview', 'no_cookie.view_template_version_preview',
'view_template_versions', 'view_template_versions',
'whitelist', 'guest_list',
'who_can_use_notify', 'who_can_use_notify',
'who_its_for', 'who_its_for',
} }
@@ -1285,7 +1285,7 @@ class OrgNavigation(Navigation):
'view_template_version', 'view_template_version',
'no_cookie.view_template_version_preview', 'no_cookie.view_template_version_preview',
'view_template_versions', 'view_template_versions',
'whitelist', 'guest_list',
'who_can_use_notify', 'who_can_use_notify',
'who_its_for', 'who_its_for',
} }

2
app/templates/views/api/index.html
View File

@@ -19,7 +19,7 @@
<a class="govuk-link govuk-link--no-visited-state pill-separate-item" href="{{ url_for('.api_keys', service_id=current_service.id) }}">API keys</a> <a class="govuk-link govuk-link--no-visited-state pill-separate-item" href="{{ url_for('.api_keys', service_id=current_service.id) }}">API keys</a>
</div> </div>
<div class="govuk-grid-column-one-third"> <div class="govuk-grid-column-one-third">
<a class="govuk-link govuk-link--no-visited-state pill-separate-item" href="{{ url_for('.whitelist', service_id=current_service.id) }}">Guest list</a> <a class="govuk-link govuk-link--no-visited-state pill-separate-item" href="{{ url_for('.guest_list', service_id=current_service.id) }}">Guest list</a>
</div> </div>
<div class="govuk-grid-column-one-third"> <div class="govuk-grid-column-one-third">
<a class="govuk-link govuk-link--no-visited-state pill-separate-item" href="{{ url_for(callbacks_link, service_id=current_service.id) }}">Callbacks</a> <a class="govuk-link govuk-link--no-visited-state pill-separate-item" href="{{ url_for(callbacks_link, service_id=current_service.id) }}">Callbacks</a>

6
tests/app/main/views/test_api_integration.py
View File

@@ -421,7 +421,7 @@ def test_should_show_whitelist_page(
mock_get_whitelist, mock_get_whitelist,
): ):
page = client_request.get( page = client_request.get(
'main.whitelist', 'main.guest_list',
service_id=SERVICE_ONE_ID, service_id=SERVICE_ONE_ID,
) )
textboxes = page.find_all('input', {'type': 'text'}) textboxes = page.find_all('input', {'type': 'text'})
@@ -443,7 +443,7 @@ def test_should_update_whitelist(
]) ])
client_request.post( client_request.post(
'main.whitelist', 'main.guest_list',
service_id=SERVICE_ONE_ID, service_id=SERVICE_ONE_ID,
_data=data, _data=data,
) )
@@ -459,7 +459,7 @@ def test_should_validate_whitelist_items(
): ):
page = client_request.post( page = client_request.post(
'main.whitelist', 'main.guest_list',
service_id=SERVICE_ONE_ID, service_id=SERVICE_ONE_ID,
_data=OrderedDict([ _data=OrderedDict([
('email_addresses-1', 'abc'), ('email_addresses-1', 'abc'),