darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-19 05:59:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

conversations only looks for 404 errors from inbound sms

Browse Source 
stops masking some 503s in tests
This commit is contained in:
Leo Hemsted
2018-05-03 15:40:24 +01:00
parent 09a8e863a4
commit 236339435c
3 changed files with 32 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/main/views/conversation.py
View File

@@ -94,7 +94,9 @@ def get_conversation_partials(service_id, user_number):
def get_user_number(service_id, notification_id):
try:
user_number = service_api_client.get_inbound_sms_by_id(service_id, notification_id)['user_number']
except HTTPError:
except HTTPError as e:
if e.status_code != 404:
raise
user_number = notification_api_client.get_notification(service_id, notification_id)['to']
return format_phone_number_human_readable(user_number)