darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-25 08:44:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add test for plural form of error message

Browse Source
This commit is contained in:
Chris Hill-Scott
2020-01-20 15:50:16 +00:00
parent bc7deebcc7
commit 1fc0f58541
1 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/app/test_utils.py
View File

@@ -415,9 +415,10 @@ def test_get_letter_validation_error_for_unknown_error():
} }
@pytest.mark.parametrize('error_message, expected_title, expected_content, expected_summary', [ @pytest.mark.parametrize('error_message, invalid_pages, expected_title, expected_content, expected_summary', [
( (
'letter-not-a4-portrait-oriented', 'letter-not-a4-portrait-oriented',
[2],
'Your letter is not A4 portrait size', 'Your letter is not A4 portrait size',
( (
'You need to change the size or orientation of page 2. ' 'You need to change the size or orientation of page 2. '
@@ -428,8 +429,22 @@ def test_get_letter_validation_error_for_unknown_error():
'Files must meet our letter specification.' 'Files must meet our letter specification.'
), ),
), ),
(
'letter-not-a4-portrait-oriented',
[2, 3, 4],
'Your letter is not A4 portrait size',
(
'You need to change the size or orientation of pages 2, 3 and 4. '
'Files must meet our letter specification.'
),
(
'Validation failed because pages 2, 3 and 4 are not A4 portrait size.'
'Files must meet our letter specification.'
),
),
( (
'content-outside-printable-area', 'content-outside-printable-area',
[2],
'Your content is outside the printable area', 'Your content is outside the printable area',
( (
'You need to edit page 2.' 'You need to edit page 2.'
@@ -443,6 +458,7 @@ def test_get_letter_validation_error_for_unknown_error():
), ),
( (
'letter-too-long', 'letter-too-long',
[2],
'Your letter is too long', 'Your letter is too long',
( (
'Letters must be 10 pages or less. ' 'Letters must be 10 pages or less. '
@@ -457,11 +473,12 @@ def test_get_letter_validation_error_for_unknown_error():
def test_get_letter_validation_error_for_known_errors( def test_get_letter_validation_error_for_known_errors(
client_request, client_request,
error_message, error_message,
invalid_pages,
expected_title, expected_title,
expected_content, expected_content,
expected_summary, expected_summary,
): ):
error = get_letter_validation_error(error_message, invalid_pages=[2], page_count=13) error = get_letter_validation_error(error_message, invalid_pages=invalid_pages, page_count=13)
detail = BeautifulSoup(error['detail'], 'html.parser') detail = BeautifulSoup(error['detail'], 'html.parser')
summary = BeautifulSoup(error['summary'], 'html.parser') summary = BeautifulSoup(error['summary'], 'html.parser')