From 1f3c3aba3239db180830d5ed76cc9510c3318ead Mon Sep 17 00:00:00 2001 From: Beverly Nguyen Date: Tue, 22 Jul 2025 13:02:12 -0700 Subject: [PATCH] update manage_tempaltes --- tests/__init__.py | 10 +++++----- tests/app/main/views/test_accept_invite.py | 2 +- tests/app/main/views/test_platform_admin.py | 2 +- tests/app/main/views/test_template_folders.py | 4 ++-- tests/app/utils/test_user.py | 6 +++--- tests/app/utils/test_user_permissions.py | 4 ++-- 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/tests/__init__.py b/tests/__init__.py index 98519744a..27776c25a 100644 --- a/tests/__init__.py +++ b/tests/__init__.py @@ -77,11 +77,11 @@ def user_json( if permissions is None: permissions = { str(generate_uuid()): [ - "view_activity", - "send_texts", - "send_emails", - "manage_users", - "manage_templates", + ServicePermission.VIEW_ACTIVITY, + ServicePermission.SEND_TEXTS, + ServicePermission.SEND_EMAILS, + ServicePermission.MANAGE_USERS, + ServicePermission.MANAGE_TEMPLATES, ServicePermission.MANAGE_SETTINGS, "manage_api_keys", ] diff --git a/tests/app/main/views/test_accept_invite.py b/tests/app/main/views/test_accept_invite.py index 2d7c1444a..76ebe658f 100644 --- a/tests/app/main/views/test_accept_invite.py +++ b/tests/app/main/views/test_accept_invite.py @@ -5,7 +5,7 @@ from flask import url_for from freezegun import freeze_time import app -from app.enums import ServicePermission +from app.enums import AuthType, ServicePermission from notifications_python_client.errors import HTTPError from tests import service_json from tests.conftest import ( diff --git a/tests/app/main/views/test_platform_admin.py b/tests/app/main/views/test_platform_admin.py index 20b1307f3..681825121 100644 --- a/tests/app/main/views/test_platform_admin.py +++ b/tests/app/main/views/test_platform_admin.py @@ -1179,7 +1179,7 @@ def test_get_users_report(client_request, platform_admin_user, mocker): "permissions": { "test service": [ ServicePermission.MANAGE_USERS, - "manage_templates", + ServicePermission.MANAGE_TEMPLATES, ServicePermission.MANAGE_SETTINGS, ServicePermission.SEND_TEXTS, ServicePermission.SEND_EMAILS, diff --git a/tests/app/main/views/test_template_folders.py b/tests/app/main/views/test_template_folders.py index c3dffeee1..113aae861 100644 --- a/tests/app/main/views/test_template_folders.py +++ b/tests/app/main/views/test_template_folders.py @@ -608,7 +608,7 @@ def test_get_manage_folder_viewing_permissions_for_users_not_visible_when_no_man active_user_with_permissions["permissions"][SERVICE_ONE_ID] = [ ServicePermission.SEND_TEXTS, ServicePermission.SEND_EMAILS, - "manage_templates", + ServicePermission.MANAGE_TEMPLATES, "manage_api_keys", ServicePermission.VIEW_ACTIVITY, ] @@ -862,7 +862,7 @@ def test_manage_folder_users_doesnt_change_permissions_current_user_cannot_manag active_user_with_permissions["permissions"][SERVICE_ONE_ID] = [ ServicePermission.SEND_TEXTS, ServicePermission.SEND_EMAILS, - "manage_templates", + ServicePermission.MANAGE_TEMPLATES, "manage_api_keys", ServicePermission.VIEW_ACTIVITY, ] diff --git a/tests/app/utils/test_user.py b/tests/app/utils/test_user.py index d3c32e4c1..a4d97f6db 100644 --- a/tests/app/utils/test_user.py +++ b/tests/app/utils/test_user.py @@ -36,7 +36,7 @@ def test_permissions( request.view_args.update({"service_id": "foo"}) api_user_active["permissions"] = { - "foo": [ServicePermission.MANAGE_USERS, "manage_templates", ServicePermission.MANAGE_SETTINGS] + "foo": [ServicePermission.MANAGE_USERS, ServicePermission.MANAGE_TEMPLATES, ServicePermission.MANAGE_SETTINGS] } api_user_active["services"] = ["foo", "bar"] @@ -66,7 +66,7 @@ def test_permissions_forbidden( request.view_args.update({"service_id": "foo"}) api_user_active["permissions"] = { - "foo": [ServicePermission.MANAGE_USERS, "manage_templates", ServicePermission.MANAGE_SETTINGS] + "foo": [ServicePermission.MANAGE_USERS, ServicePermission.MANAGE_TEMPLATES, ServicePermission.MANAGE_SETTINGS] } api_user_active["services"] = ["foo", "bar"] @@ -179,7 +179,7 @@ def test_user_with_no_permissions_to_service_goes_to_templates( api_user_active, ): api_user_active["permissions"] = { - "foo": [ServicePermission.MANAGE_USERS, "manage_templates", ServicePermission.MANAGE_SETTINGS] + "foo": [ServicePermission.MANAGE_USERS, ServicePermission.MANAGE_TEMPLATES, ServicePermission.MANAGE_SETTINGS] } api_user_active["services"] = ["foo", "bar"] client_request.login(api_user_active) diff --git a/tests/app/utils/test_user_permissions.py b/tests/app/utils/test_user_permissions.py index 991c6ab34..2a0347e4b 100644 --- a/tests/app/utils/test_user_permissions.py +++ b/tests/app/utils/test_user_permissions.py @@ -11,14 +11,14 @@ from app.utils.user_permissions import ( ("db_permissions", "expected_ui_permissions"), [ ( - ["manage_templates"], + [ServicePermission.MANAGE_TEMPLATES], {ServicePermission.MANAGE_TEMPLATES}, ), ( [ ServicePermission.SEND_TEXTS, ServicePermission.SEND_EMAILS, - "manage_templates", + ServicePermission.MANAGE_TEMPLATES, "some_unknown_permission", ], {