darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-10 01:55:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Can remove sms sender.

Browse Source
This commit is contained in:
Adam Shimali
2016-07-01 16:32:21 +01:00
parent 3bfcf0f8b3
commit 1efd8506db
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/main/forms.py
View File

@@ -327,5 +327,5 @@ class ServiceSmsSender(Form):
def validate_sms_sender(form, field): def validate_sms_sender(form, field):
import re import re
if not re.match('^[a-zA-Z0-9\s]+$', field.data): if field.data and not re.match('^[a-zA-Z0-9\s]+$', field.data):
raise ValidationError('Sms text message sender can only contain alpha-numeric characters') raise ValidationError('Sms text message sender can only contain alpha-numeric characters')

4
tests/app/main/test_validators.py
View File

@@ -131,6 +131,10 @@ def test_sms_sender_form_validation(app_, mock_get_user_by_email):
form.validate() form.validate()
assert not form.errors assert not form.errors
form.sms_sender.data = ''
form.validate()
assert not form.errors
form.sms_sender.data = 'morethanelevenchars' form.sms_sender.data = 'morethanelevenchars'
form.validate() form.validate()
assert "Text message sender can't be longer than 11 characters" == form.errors['sms_sender'][0] assert "Text message sender can't be longer than 11 characters" == form.errors['sms_sender'][0]