Put templates on service model

We do a lot of logic around choosing which templates to show. This logic
is all inside one view method.

It makes it cleaner to break this logic up into functions. But this
would mean passing around variables from one function to another.
Putting these methods onto a class (the service model) means that
there’s a place to store this data (rather than having to pass it around
a lot).

Making this code more manageable is important so that when we have
templates and folders it’s easy to encapsulate the logic around
combining the two.

app/main/views/conversation.py

@@ -4,7 +4,7 @@ from notifications_python_client.errors import HTTPError
 from notifications_utils.recipients import format_phone_number_human_readable
 from notifications_utils.template import SMSPreviewTemplate
 
-from app import notification_api_client, service_api_client
+from app import current_service, notification_api_client, service_api_client
 from app.main import main
 from app.main.forms import SearchTemplatesForm
 from app.utils import user_has_permissions
@@ -44,13 +44,7 @@ def conversation_reply(
     service_id,
     notification_id,
 ):
-
-    templates = [
-        template
-        for template in service_api_client.get_service_templates(service_id)['data']
-        if template['template_type'] == 'sms'
-    ]
-
+    templates = current_service.templates_by_type('sms')
     return render_template(
         'views/templates/choose-reply.html',
         templates=templates,

app/main/views/dashboard.py

@@ -72,7 +72,6 @@ def service_dashboard(service_id):
     return render_template(
         'views/dashboard/dashboard.html',
         updates_url=url_for(".service_dashboard_updates", service_id=service_id),
-        templates=service_api_client.get_service_templates(service_id)['data'],
         partials=get_dashboard_partials(service_id)
     )
 

app/main/views/templates.py

@@ -101,24 +101,6 @@ def start_tour(service_id, template_id):
 @login_required
 @user_has_permissions()
 def choose_template(service_id, template_type='all'):
-    templates = service_api_client.get_service_templates(service_id)['data']
-
-    letters_available = current_service.has_permission('letter')
-
-    available_template_types = list(filter(None, (
-        'email',
-        'sms',
-        'letter' if letters_available else None,
-    )))
-
-    templates = [
-        template for template in templates
-        if template['template_type'] in available_template_types
-    ]
-
-    has_multiple_template_types = len({
-        template['template_type'] for template in templates
-    }) > 1
 
     template_nav_items = [
         (label, key, url_for('.choose_template', service_id=current_service.id, template_type=key), '')
@@ -126,23 +108,18 @@ def choose_template(service_id, template_type='all'):
             ('All', 'all'),
             ('Text message', 'sms'),
             ('Email', 'email'),
-            ('Letter', 'letter') if letters_available else None,
+            ('Letter', 'letter') if current_service.has_permission('letter') else None,
         ])
     ]
 
-    templates_on_page = [
-        template for template in templates
-        if (
-            template_type in ['all', template['template_type']] and
-            template['template_type'] in available_template_types
-        )
-    ]
-
     return render_template(
         'views/templates/choose.html',
-        templates=templates_on_page,
-        show_search_box=(len(templates_on_page) > 7),
-        show_template_nav=has_multiple_template_types and (len(templates) > 2),
+        templates=current_service.templates_by_type(template_type),
+        show_search_box=(len(current_service.templates_by_type(template_type)) > 7),
+        show_template_nav=(
+            current_service.has_multiple_template_types
+            and (len(current_service.templates) > 2)
+        ),
         template_nav_items=template_nav_items,
         template_type=template_type,
         search_form=SearchTemplatesForm(),

app/notify_client/models.py

@@ -319,25 +319,47 @@ class Service(dict):
         ) > 1
 
     @property
-    def has_templates(self):
+    def templates(self):
+
         from app import service_api_client
-        return service_api_client.count_service_templates(
-            self.id
-        ) > 0
+
+        templates = service_api_client.get_service_templates(self.id)['data']
+
+        return [
+            template for template in templates
+            if template['template_type'] in self.available_template_types
+        ]
+
+    def templates_by_type(self, template_type):
+        return [
+            template for template in self.templates
+            if template_type in {'all', template['template_type']}
+        ]
+
+    @property
+    def available_template_types(self):
+        return [
+            channel for channel in ('email', 'sms', 'letter')
+            if self.has_permission(channel)
+        ]
+
+    @property
+    def has_templates(self):
+        return len(self.templates) > 0
+
+    @property
+    def has_multiple_template_types(self):
+        return len({
+            template['template_type'] for template in self.templates
+        }) > 1
 
     @property
     def has_email_templates(self):
-        from app import service_api_client
-        return service_api_client.count_service_templates(
-            self.id, template_type='email'
-        ) > 0
+        return len(self.templates_by_type('email')) > 0
 
     @property
     def has_sms_templates(self):
-        from app import service_api_client
-        return service_api_client.count_service_templates(
-            self.id, template_type='sms'
-        ) > 0
+        return len(self.templates_by_type('sms')) > 0
 
     @property
     def has_email_reply_to_address(self):

app/templates/views/dashboard/dashboard.html

@@ -15,7 +15,7 @@
   <div class="dashboard">
 
     <h1 class="visuallyhidden">Dashboard</h1>
-    {% if current_user.has_permissions('manage_templates') and not templates %}
+    {% if current_user.has_permissions('manage_templates') and not current_service.templates %}
       {% include 'views/dashboard/write-first-messages.html' %}
     {% endif %}