From 1e261fd3531d6efd24738066f07962ef19f78482 Mon Sep 17 00:00:00 2001
From: Beverly Nguyen <Beverly.Nguyen@gsa.gov>
Date: Wed, 18 Dec 2024 15:30:48 -0800
Subject: [PATCH] fixed testing

---
 app/main/views/send.py                     | 2 +-
 app/templates/views/edit-sms-template.html | 6 ++++--
 tests/app/main/views/test_send.py          | 2 +-
 tests/app/main/views/test_tour.py          | 2 +-
 4 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/app/main/views/send.py b/app/main/views/send.py
index 2b7a66f96..2b36e5723 100644
--- a/app/main/views/send.py
+++ b/app/main/views/send.py
@@ -483,7 +483,7 @@ def send_one_off_step(service_id, template_id, step_index):
         link_to_upload=(
             request.endpoint == "main.send_one_off_step" and step_index == 0
         ),
-        errors=form.errors if form.errors else None
+        errors=form.errors if form.errors else None,
     )
 
 
diff --git a/app/templates/views/edit-sms-template.html b/app/templates/views/edit-sms-template.html
index b46c20ffa..728b92cd6 100644
--- a/app/templates/views/edit-sms-template.html
+++ b/app/templates/views/edit-sms-template.html
@@ -33,7 +33,8 @@
           {{ form.name(param_extensions={
             "extra_form_group_classes": "margin-bottom-2",
             "id": "name",
-            "required": True
+            "required": True,
+            "hint": {"text": "Your recipients will not see this"}
           }) }}
           {{ textbox(
             form.template_content,
@@ -53,7 +54,8 @@
           <div class="grid-col-12">
             <div class="template-content-count" bg-color="red">
               <div data-module="update-status" data-target="template_content"
-                data-updates-url="{{ url_for('.count_content_length', service_id=current_service.id, template_type='sms') }}">
+                data-updates-url="{{ url_for('.count_content_length', service_id=current_service.id, template_type='sms') }}"
+                aria-live="polite">
                 &nbsp;
               </div>
             </div>
diff --git a/tests/app/main/views/test_send.py b/tests/app/main/views/test_send.py
index 806474c49..0ab770c18 100644
--- a/tests/app/main/views/test_send.py
+++ b/tests/app/main/views/test_send.py
@@ -1521,7 +1521,7 @@ def test_link_to_upload_not_offered_when_entering_personalisation(
 
     # We’re entering personalization
     assert page.select_one("input[type=text]")["name"] == "placeholder_value"
-    assert page.select_one("label[for=placeholder_value]").text.strip() == "name"
+    assert page.select_one("label[for=phone-number]").text.strip() == "name"
     # No ‘Upload’ link shown
     assert len(page.select("main a")) == 0
     assert "Upload" not in page.select_one("main").text
diff --git a/tests/app/main/views/test_tour.py b/tests/app/main/views/test_tour.py
index 2916d0887..9a2b8f053 100644
--- a/tests/app/main/views/test_tour.py
+++ b/tests/app/main/views/test_tour.py
@@ -175,7 +175,7 @@ def test_should_show_empty_text_box(
     # shouldn’t also be set on the textbox itself
     assert "data-module" not in textbox
     assert (
-        normalize_spaces(page.select_one("label[for=placeholder_value]").text) == "one"
+        normalize_spaces(page.select_one("label[for=phone-number]").text) == "one"
     )