darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-15 07:18:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1153 from alphagov/forget-me

Browse Source 
Remove remember me cookie
This commit is contained in:
Leo Hemsted
2017-03-06 09:39:52 +00:00
committed by GitHub
parent 393cb5b2da 85efe0d117
commit 1cacd92411
12 changed files with 8 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
tests/app/main/views/test_sign_in.py
View File

@@ -144,45 +144,3 @@ def test_should_attempt_redirect_when_user_is_pending(
'password': 'val1dPassw0rd!'})
assert response.location == url_for('main.resend_email_verification', _external=True)
assert response.status_code == 302
def test_not_fresh_session_login_redirects_to_dashboard(
logged_in_client,
api_user_active,
mock_login,
mock_get_user_by_email,
mock_verify_password,
mock_get_services_with_one_service,
):
with logged_in_client.session_transaction() as session:
assert session['_fresh']
session['_fresh'] = False
# This should skip the two factor
response = logged_in_client.post(
url_for('main.sign_in'), data={
'email_address': api_user_active.email_address,
'password': 'val1dPassw0rd!'})
assert response.status_code == 302
service_dct = mock_get_services_with_one_service(api_user_active.id)['data'][0]
assert response.location == url_for(
'main.service_dashboard', service_id=service_dct['id'], _external=True)
def test_not_fresh_session_login_redirects_to_choose_service(
logged_in_client,
api_user_active,
mock_login,
mock_get_user_by_email,
mock_verify_password,
mock_get_services,
):
with logged_in_client.session_transaction() as session:
assert session['_fresh']
session['_fresh'] = False
# This should skip the two factor
response = logged_in_client.post(
url_for('main.sign_in'), data={
'email_address': api_user_active.email_address,
'password': 'val1dPassw0rd!'})
assert response.status_code == 302
assert response.location == url_for('main.choose_service', _external=True)

17
tests/app/main/views/test_two_factor.py
View File

@@ -141,23 +141,6 @@ def test_should_login_user_when_multiple_valid_codes_exist(
assert response.status_code == 302
def test_remember_me_set(
client,
api_user_active,
mock_get_user,
mock_get_user_by_email,
mock_check_verify_code,
mock_get_services_with_one_service,
):
with client.session_transaction() as session:
session['user_details'] = {
'id': api_user_active.id,
'email': api_user_active.email_address}
response = client.post(url_for('main.two_factor'),
data={'sms_code': '23456', 'remember_me': True})
assert response.status_code == 302
def test_two_factor_should_set_password_when_new_password_exists_in_session(
client,
api_user_active,

18
tests/app/test_event_handlers.py
View File

@@ -1,9 +1,6 @@
from unittest.mock import ANY
from app.event_handlers import (
on_user_logged_in,
on_user_login_confirmed
)
from app.event_handlers import on_user_logged_in
def test_on_user_logged_in_calls_events_api(app_, api_user_active, mock_events):
@@ -14,16 +11,3 @@ def test_on_user_logged_in_calls_events_api(app_, api_user_active, mock_events):
{'browser_fingerprint':
{'browser': ANY, 'version': ANY, 'platform': ANY, 'user_agent_string': ''},
'ip_address': ANY, 'user_id': str(api_user_active.id)})
def test_on_user_login_confirmed_in_calls_events_api(app_, api_user_active, mock_events):
with app_.test_request_context():
with app_.test_client() as client:
client.login(api_user_active) # user must have been logged in already.
on_user_login_confirmed(app_)
mock_events.assert_called_with('sucessful_login_remember_me',
{'browser_fingerprint':
{'browser': ANY, 'version': ANY, 'platform': ANY, 'user_agent_string': ''},
'ip_address': ANY, 'user_id': str(api_user_active.id)})